Skip to content

onClose pip listener and detect lack of PIP permission #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

onClose pip listener and detect lack of PIP permission #2

wants to merge 1 commit into from

Conversation

thgcst
Copy link

@thgcst thgcst commented Apr 28, 2022 •
edited
Loading

I noticed that if the user disables PIP permission, the app would crash when enterPipMode is called.
Also added a listener for when the PIP window is closed.

@thgcst thgcst changed the title onClose pip listener / detect lack of PIP permission onClose pip listener and detect lack of PIP permission Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thgcst