Skip to content

Conversation

@pull
Copy link

@pull pull bot commented May 29, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

Fix pages module package detection, restrict CI push events to dev and master, mark generated prop-types as dev-only, and update the changelog accordingly.

Bug Fixes:

  • Fix pages module package detection by checking module presence and init.py suffix.

Enhancements:

  • Mark generated prop-types JS distribution file as dev-only.

CI:

  • Restrict push triggers in the testing workflow to dev and master branches.

Documentation:

  • Add the pages module package check fix entry to the CHANGELOG.

@pull pull bot added the ⤵️ pull label May 29, 2025
@pull pull bot merged commit bd06cc8 into admariner:dev May 29, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented May 29, 2025

Reviewer's Guide

This PR simplifies package detection in the pages module by adding an existence guard and using a direct string check, extends the GitHub Actions testing workflow to trigger on dev and master branches for push events, flags the generated prop types resource as development-only, and records the pages module package check fix in the changelog.

File-Level Changes

Change Details Files
Refactor package detection logic with module existence guard and endswith check
  • Added check for module_name in sys.modules
  • Replaced Path-based filename comparison with string endswith
  • Removed redundant variable assignments
dash/_pages.py
Extend CI workflow triggers for push events
  • Added ‘branches’ list for dev and master under push
.github/workflows/testing.yml
Mark generated prop types as development-only
  • Inserted dev_only=true flag into js_dist configuration
dash/development/_generate_prop_types.py
Log pages module package check fix in changelog CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant