-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] dev from plotly:dev #329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
update flask
Fix query string parsing regression introduced in 2.18.2 #3106
Reviewer's GuideThis PR fixes a regression in query string parsing within the pages module by simplifying input checks and preserving blank values, expands the lint-staged configuration to include pylint, flake8, and black on both source and test files, removes obsolete skip/xfail decorators addressing a now-resolved Werkzeug transfer-encoding bug across multiple tests, and updates the CHANGELOG with the new fix entry. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Giga Summary• Sync dev branch with upstream plotly:dev
Quality Assessment• Improved query parsing, refined linting, and simplified tests. Quality Score: 8/10 (Threshold: 7/10) 💬 Detailed comments have been added to specific code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detailed code review comments
| query_string = search[1:] | ||
|
|
||
| parsed_qs = parse_qs(query_string, keep_blank_values=True) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change adding keep_blank_values=True to preserve empty parameters in query string parsing
| // Python checks (run from root, using root venv) | ||
| "*.py": (filenames) => [ | ||
| "dash/*.py": (filenames) => [ | ||
| `${venvBin("python")} -m pylint --rcfile=.pylintrc ${filenames.join( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improved linting configuration by separating rules for source vs test files
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Fix query string parsing regression introduced in v2.18.2, unskip related integration tests, and update lint-staged config to include flake8 and black checks
Bug Fixes:
CI:
Documentation:
Tests: