Incorporate Findings from Review #34

BirgitBoss · 2025-09-03T16:16:24Z

Findings via PR #10

Major Bugs:

Technical Data Battery: correct expectedNumberOfCycle in TechnicalDataBattery (before NumberFullCycles)
Nameplate mainly: correct Characteristic for MulitLanguageProperties to shared:MultiLanguageTexts
Technical Data Battery: correct payload names for internalResistanceIncreaseOfBatteryCell, Pack and Module (denoted names for initialResistance)
TechnicalData Battery: define new Characteristic :TemperatureRangeBoundary for temperature temperatureRangeIdleStateLowerBoundary and temperatureRangeIdleStateUpperBoundary (before it was range min/max but this would be redundant)
Performance Battery: correct data type of capacitiyFade: does not have timestamp (BUG capacityFade does not have timestamp batterypass/BatteryPassDataModel#30) - not yet done
Technical Data: fix property names of initialInternalResistanceOnBatteryCellLevel, PackLevel and ModuleLevel: remove Level, use "Of" instad of "on" to be consistent with DIN SPEC 91100 and internalResistanceIncreaseBattery*
remove generated .aasx, .aas.xml and aas.json for SMT for which aasx is the master and not the aspect model because semanticIds of generated files and original files differ

Minor Bugs:

fix bugs with respect to wrong language tags
remove incorrect preferred names
newly generated files
new version of ESMF CLI was used: validation errors corrected
remove duplicate definitions from .ttl files like :productOrSectorSpecificCarbonFootprints
fix typos in element names

Major changes:

add enumeration and values for Contact Information
- add enumeration and values for Markings
deviate from Contact Information recommendation and do not use IRDI as values if there is an enumeration and values defined
use bp: <urn:samm:io.BatteryPass.Performance:1.2.1#> instead of bp: <urn:samm:io.BatteryPass.Performance:1.2.0#>
use cx: <urn:samm:io.catenax.pcf:8.0.0#> instead of cx: <urn:samm:io.catenax.pcf:7.0.0#>
add Namespace.ttl to HandoverDocumention, MaterialComposition, Circularity, ProductCondition. NOTE: not all namespaces already contain a Namespace.ttl

Improvements:

update some preferred names
add German preferred names for some properties
add examples values for Nameplate und ContactInformation for MultiLanguageTexts #35 - Attention: they are not considered and may lead to validation errors in future
add example values
formatting
fix typos
new version of ESMF CLI was used: payload names now considered when generating json files etc.
READMEs updated

Please be aware: some of the generated files also changed because of changes in reused Aspect Models from BatteryPass Consortium or Tractus-X/Catena-X, e.g.

-- batterypass/BatteryPassDataModel#23: remove editorial special char from descriptions
-- batterypass/BatteryPassDataModel#25: Circularity.ValidEmailAddress wrong regex
-- batterypass/BatteryPassDataModel#27: GeneralProductInformation:1.2.0 exampleValue for addressCountry is wrong
-- batterypass/BatteryPassDataModel#32: NumberOfFullCycles and others should be xsd:positiveInteger
-- batterypass/BatteryPassDataModel#31 ratedEnergy/CertifiedUsableBatteryEnergy: data type & no negative values #31
-- batterypass/BatteryPassDataModel#21 add descriptions to properties
-- batterypass/BatteryPassDataModel#20 optional properties? Add cardinality to Performance, MaeterialComposition and Circularity properties
-- batterypass/BatteryPassDataModel#19 Add example values to Performance, MaeterialComposition and Circularity properties

correct typo from :kilogramperkilowatthour to :KilogramPerKilowattHour
correct example value from samm:exampleValue "7439-93-2 " to samm:exampleValue "7439-93-2" .

Open issues for generated files:

[BUG] SAMM2AASX Generator: SML handling, semanticId, payload Name and missing properties eclipse-esmf/esmf-sdk#766 [BUG] SAMM2AASX Generator: SML handling, semanticId, payload Name and missing properties

remove wrong preferred name fix language for preferred name

- fix language issues - formatting

- fix German preferredName: Fußabdruck instead of Footprint - fix language issues - add German preferred name for productOrSectorSepcificCarbonFootprints

- adding example value for Logo - formatting

add exampleValue for company logo

…OfCycles

io.admin-shell.idta.batterypass.carbon_footprint/1.0.0/gen/CarbonFootprintBattery.json

io.admin-shell.idta.batterypass.technical_data/1.0.0/gen/TechnicalDataBattery.json

io.admin-shell.idta.carbon_footprint.pact/1.0.0/gen/CarbonFootprintPact.json

minor fixes

…for type of email etc.

BirgitBoss · 2025-09-12T13:34:45Z

@tobzahn the process requires a re-review. But please review #34 instead that contains the changes.

tobzahn

There are still plenty non-printable characters, for example in TechnicalDataBattery.aas.json in many description texts. I think this should be changed.

io.admin-shell.idta.batterypass.technical_data/1.0.0/gen/TechnicalDataBattery.json

tobzahn · 2025-09-26T12:31:49Z

io.admin-shell.idta.batterypass.technical_data/1.0.0/technicalProperties_shared.ttl

+  [ samm:property :initialInternalResistanceOfBatteryCell; samm:payloadName "InitialInternalResistanceOfBatteryCell" ] 
+  [ samm:property :initialInternalResistanceOfBatteryPack; samm:payloadName "InitialInternalResistanceOfBatteryPack" ] 
+  [ samm:property :initialInternalResistanceOfBatteryModule; samm:optional true; samm:payloadName "InitialInternalResistanceOnBatteryModule" ] 
+  [ samm:property :internalResistanceIncreaseOfBatteryCell; samm:optional true; samm:payloadName "InternalResistanceIncreaseOfBatteryCell" ] 


Are InitialInternalResistanceOnBatteryModule / InternalResistanceIncreaseOfBatteryCell / InternalResistanceIncreaseOfBatteryPack dynamic data? If yes, are they correct in this data model or should they be part of batterypass.product_condition?

DIN DKE SPEC 99100 classifies them as static, this is why they are part of technical data and not of Product Condition

Okay, therefore the "initial", I get it. For fields like this I think an explanation like "initial value during manufacturing, not to be updated" might avoid misunderstandings. Thanks for the explanation.

I unresolved the findings so that decription might be improved

io.admin-shell.idta.handover_documentation/2.0.0/gen/HandoverDocumentation.aas.json

tobzahn · 2025-09-29T07:01:38Z

io.admin-shell.idta.handover_documentation/2.0.0/gen/HandoverDocumentation.aas.json

            "keys" : [ {
              "type" : "GlobalReference",
-              "value" : "https://api.eclass-cdp.com/0173-1-02-ABI503-003"
+              "value" : "file:///C:/Users/bsb2si/OneDrive%20-%20Bosch%20Group/__localWorkCloud/__git/admin-shell-io.smt-semantic-models/cli/0173-1%2302-ABI503%23003"


URL hard coded with Bosch in the string...
There are many hard coded URLs in this file I will not tag all of them.

there should be no new semantic Ids introduced. IDTA have already defined them for HandoverDocumentation. See also my comments here

This is a bug in the generator and not the value as defined in the .ttl. The model itself seems to be correct. The bug is addressed in eclipse-esmf/esmf-sdk#766. Added to overview of known issues in this PR

tobzahn · 2025-09-29T07:07:49Z

io.admin-shell.idta.handover_documentation/2.0.0/Namespace.ttl

+
+: a samm:Namespace ;
+   samm:preferredName "namespace for handover documentation"@en ;
+   samm:description "This namespace is reserved for the Aspect Models and elements conformant to Submodel Template Specification (SMT) IDTA-02004 Handover Documentation, Version 2.0."@en .


A content-wise description is missing from my point of view. What documents should be put in here? Some documents seem to be required to be put into the CircularityBattery data model.

@tobzahn sorry, I do not understand: this is the namespace for handover documentation, not for Circulartiy. For ciruclarity there would be another namespace description. So far not all namespaces do have such a namespace.ttl: this is new in SAMM and I just wanted to test it whether it helps.

So in this namespace only .ttl for Handover Documentation that reflext the mentioned IDTA specification are contained.

Please check if the improved description for 6dd3612 helps. Thank you

Sorry for the confusion. Let me rephrase: To me, it is unclear how to use the HandoverDocumentation data model. I do not understand what can or needs to be put into the data model, therefore I think the description needs to be more clear. (In the diff you linked I did not see an updated description, but maybe I am just looking in the wrong place.)

tobzahn · 2025-09-29T12:54:37Z

Questions regarding the ProductCarbonFootprint data model:

why 'pcf2CoEq' and not 'pcfCo2Eq'?
why is 'lifeCyclePhases' a String and a not a fixed set of values?
why is 'pcfCalculationMethods' also a String and not a fixed set of values?

I am asking because my understanding is that there need to be several different life cycle phases for all batteries, and since those phases are defined in the regulation this should also be defined in the data model. But if it is just a string everybody will use a different string.

tobzahn · 2025-10-02T11:57:26Z

According to the regulation:

Annex XIII 4(c): A battery passport must include information on the status of the battery.

The status of the battery must be defined as ‘original’, ‘repurposed’, ‘re-used’, ‘remanufactured’ or ‘waste’.

A new battery passport must be issued when a battery was subject to remanufacturing, repurpose or one of the treatment operations preparing for re-use and preparing for repurpose and is placed on the market again.

Therefore, I would expect to see an attribute called 'batteryStatus' in the product condition data model, with the possible attributes 'original', 'remanufactured', 'repurposed' or 'dismantled'. I found the attribute in the nameplate, but I assume batteryStatus is dynamic?

tobzahn · 2025-10-07T14:41:24Z

In the battery regulation it is mentioned that the battery passport must include the carbon footprint performance class per Article 7 of the Battery Regulation. I was looking for a corresponding parameter in the CarbonFootprint data model, but I cannot find it. Is it missing or am I looking in the wrong place?

sebastiankb

There are more major bugs: There are inconsistencies in the submodels derived from the IDTA submodel original definitions such as DNP, PCF, Doc, Tech. These include semanticIds and shortIds usage (eg, shortIds they do not start with capital letters).

io.admin-shell.idta.digital_nameplate/3.0.0/Nameplate.ttl

…as master

…tCondition

tobzahn · 2025-10-17T13:22:28Z

Is the "Draft Guidance on Data explanation required in EU battery passport" (CEN/TC 301/WG 18 "Electric vehicles batteries") already considered in this data model?

BirgitBoss added 8 commits September 3, 2025 12:18

GeneralInforamtion:

de17510

remove wrong preferred name fix language for preferred name

PACT Carbon Footpring:

b3c60de

- fix language issues - formatting

PCF:

3209795

- fix German preferredName: Fußabdruck instead of Footprint - fix language issues - add German preferred name for productOrSectorSepcificCarbonFootprints

fix Characteristics for MultiLanguageProperties

d1dc0af

update preferrred name German conformant to ECLASS

e8f58b9

Generic Technical Data:

f1a97b8

- adding example value for Logo - formatting

ContactInformation: added exampleValues + formatting

d8d9bb5

remove example value for anyURI: leads to error in validation

f34bbf5

BirgitBoss requested review from nd-circulor and sebastiankb September 3, 2025 16:20

BirgitBoss mentioned this pull request Sep 4, 2025

BatteryPass Aspect Models of joint Catena-X/IDTA expert modelling group - Version for Review #10

Draft

BirgitBoss added 8 commits September 4, 2025 17:40

fix datatype of dateOfManufacturer to xsd:date

0509203

add exampleValue for company logo

newly generated files for changed Aspect Models

17bb804

TechnicalDataBattery: fix numberOfFullCycles - must be expectedNumber…

97055c7

…OfCycles

add example values

b97e53a

newly generated files

13cc1e0

example values added

c7d4eeb

ContactInformation: some additional example values + formatting

a33add7

newly generated files

387288f

BirgitBoss mentioned this pull request Sep 5, 2025

Provide suitable example values for properties with Characteristic MultiLanguageTexts #35

Closed

tobzahn reviewed Sep 5, 2025

View reviewed changes

tobzahn and others added 9 commits September 5, 2025 17:41

minor fixes

dce6727

README: new CLI for validation

708dc32

circularity: newly generated files

ecfa8ff

PCF: removed redundant PcfCalculationSet

ace85d6

Aspect renamed from CarbonFootprint to CarbonFootprintBattery

1236b57

Merge pull request #37 from tobzahn/batterypass

48b90f3

minor fixes

Technical Data: fix type

3b4de18

PCF: Type + formatting

b75624d

newly generated files

a1ddbf8

BirgitBoss added 8 commits September 12, 2025 14:35

ContactInformation: fix example values + use values from samm:Values …

a29e368

…for type of email etc.

ContactInformation: enumerations and enumeration values added

2849bd7

CarbonFootprintBattey: use io.catenax.pcf:8.00 instead of 7.0.0

57cf3da

TechnicalData Battery: remove properties not used

a09684c

PCF PACT: remove file containing redudant elements only

ad53348

CarbonFooprint and CarbonFootpringPACT: use io.catenax.pcf:8.0.0

6826dc0

newly generated files

961ce44

shared Markings: add enumeration and value definitions

52a8612

BirgitBoss requested a review from tobzahn September 12, 2025 13:33

BirgitBoss added 4 commits September 19, 2025 15:45

Handover Docu: fix typo in payload name

980e191

Handover Docu: fix typo in payload name

35542ef

Handover Docu: document deviation and issue number for Languages

8e072dc

Handover Docu: fix cardainlity for documentVersions: it is mandatory

7103ff7

tobzahn reviewed Sep 26, 2025

View reviewed changes

io.admin-shell.idta.batterypass.technical_data/1.0.0/gen/TechnicalDataBattery.json Show resolved Hide resolved

tobzahn reviewed Sep 26, 2025

View reviewed changes

tobzahn reviewed Sep 29, 2025

View reviewed changes

sebastiankb requested changes Oct 9, 2025

View reviewed changes

io.admin-shell.idta.digital_nameplate/3.0.0/Nameplate.ttl Show resolved Hide resolved

io.admin-shell.idta.digital_nameplate/3.0.0/Nameplate.ttl Show resolved Hide resolved

remove generated .aasx, aas.xml and aas.json files for SMT with aasx …

6dd3612

…as master

BirgitBoss requested a review from sebastiankb October 9, 2025 14:41

BirgitBoss added 4 commits October 9, 2025 16:51

improved documentation of namespace handover documentation

e773e82

formatting only

def2fe7

formatting only

eda6acc

add namespace.ttl also to Circularity, MaterialComposition and Produc…

985dca3

…tCondition

BirgitBoss requested a review from tobzahn October 9, 2025 15:05

Incorporate Findings from Review #34

Are you sure you want to change the base?

Incorporate Findings from Review #34

Uh oh!

Conversation

BirgitBoss commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

BirgitBoss commented Sep 12, 2025

Uh oh!

tobzahn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tobzahn Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

BirgitBoss Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

tobzahn Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

BirgitBoss Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tobzahn Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

sebastiankb Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BirgitBoss Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobzahn Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

BirgitBoss Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tobzahn Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

tobzahn commented Sep 29, 2025

Uh oh!

tobzahn commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobzahn commented Oct 7, 2025

Uh oh!

sebastiankb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

tobzahn commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

BirgitBoss commented Sep 3, 2025 •

edited

Loading

sebastiankb Oct 9, 2025 •

edited

Loading

BirgitBoss Oct 9, 2025 •

edited

Loading

BirgitBoss Oct 9, 2025 •

edited

Loading

tobzahn commented Oct 2, 2025 •

edited

Loading