Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move skus last queried time to state #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: move skus last queried time to state #33

wants to merge 3 commits into from
+150 −89

Conversation

duynguyen
Copy link
Collaborator

@duynguyen duynguyen commented Feb 21, 2025 •
edited
Loading

Current state:

skusLastQueriedTimestamp,sku1,timestamp,sku2,timestamp,sku3,timestamp,...

This PR moves skusLastQueriedTimestamp to state lib with key name <locale>.skusLastQueriedAt.
The state file is now a csv file with format:

sku1,timestamp,hash
sku2,timestamp,hash
sku3,timestamp,hash

hash will be used to compare generated HTML version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicagno dicagno Awaiting requested review from dicagno

@BaDos BaDos Awaiting requested review from BaDos

@herzog31 herzog31 Awaiting requested review from herzog31

@jkf276 jkf276 Awaiting requested review from jkf276

@noruiz noruiz Awaiting requested review from noruiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@duynguyen