Skip to content

Skill for Core component forms#5

Open
lovelymandal16 wants to merge 1 commit into
adobe-rnd:formsfrom
lovelymandal16:forms
Open

Skill for Core component forms#5
lovelymandal16 wants to merge 1 commit into
adobe-rnd:formsfrom
lovelymandal16:forms

Conversation

@lovelymandal16
Copy link
Copy Markdown

Update forms orchestrator routing, planner, scaffold-form, and sync-forms

Made-with: Cursor

dmaurya929 pushed a commit that referenced this pull request Apr 28, 2026
* feat(aem-design): scaffold plugin skeleton

- plugin.json (Apache-2.0, Adobe author, v0.1.0)
- tile.json listing the 5 design skills
- empty skills/ and evals/ (populated by subsequent commits)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design): import hardened skills from stardust-plugin

5 design skills (aem-design navigator, brand, briefings, wireframes, prototype)
plus _shared/ (preflight, skill-contract, soft-deps, fallback-brainstorm,
fallback-critique).

All skills use /aem-design:* slash commands, aem-design:provenance markers,
no absolute paths, and no EDS dev-server references.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(aem-design): import eval packs

5 packs (aem-design-navigator, brand-extract-from-url, briefings-from-prompt,
wireframes-render, prototype-iterate). Each has task.md (setup, prompt,
expected behavior) and criteria.json (weighted rubric summing to 100).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(aem-design): plugin README

Install, skill table, soft-dep notes (superpowers, impeccable),
AGENTS.md snippet for activation reinforcement, and out-of-scope
clarification (EDS build phase is separate).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(marketplace): register aem-design

Insert alongside the other AEM entries, immediately before
aem-edge-delivery-services to group the design-phase plugin
with its downstream EDS implementation companion.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(readme): add aem-design section and install command

Adds the Designing-with-aem-design subsection with the 5 skills
(navigator + brand, briefings, wireframes, prototype) under the
AEM section, placed before Developing with Edge Delivery Services
to reflect pipeline order. Adds /plugin install aem-design to the
top install block.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(aem-design): add "When to use" / "Do NOT use" blocks per Tessl rubric

Each SKILL.md now names the triggers that should invoke it and defers to
sibling skills for out-of-scope requests, so agents with weaker description
matching hand off cleanly instead of overreaching.

* fix(aem-design/brand): enforce _provenance contract and extract real logo to aem-design/assets/

Follow-ups #1, #3, #4 from docs/superpowers/aem-design-followups.md.

- brand-profile.json now requires `_provenance` as the first top-level key
  with generated_by, source, extraction_method, synthesized_inputs
  (enumerating LLM-filled fields) and screenshots. Legacy `extraction`
  block removed. Aligns with _shared/skill-contract.md.

- brand skill now extracts the real logo on a deterministic fallback path:
  inline <svg> in header/nav → <img> with logo class/src → apple-touch-icon
  / og:image → favicon → synthesized placeholder (last resort). Output
  always lands at aem-design/assets/logo.<ext> — never icons/ — so the
  design phase stays EDS-agnostic. brand-profile.json's logo object now
  records path/format/source. brand-board.html references the asset file
  via <img>, not inline SVG.

- brand-extract-from-url eval: provenance_stamped criterion tightened to
  assert the new contract shape; new real_logo_asset criterion (10 pts)
  asserts the file exists under assets/ with logo.source set; weights
  rebalanced to sum to 100.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(aem-design): honor soft-deps delegation across skills (briefings, brand, wireframes)

Explicit decision tree at each soft-dep boundary: detect the peer slash command,
delegate when present, otherwise announce the fallback once per session and run
the inline pattern. Silent inline interviews are now a bug.

- briefings/SKILL.md Phase 2 Step 1: rewrite discovery to branch on /brainstorm
  registration. Either delegate with visible hand-off or announce fallback once.
- brand/SKILL.md conversational path: same pattern for brand discovery.
- wireframes/SKILL.md Phase 1 Step 4: same pattern for multi-page IA planning
  via /write-plan.
- evals/briefings-from-prompt: rename fallback_announced_once -> soft_deps_honored
  with tightened description covering both delegation and announcement paths.

Follow-up #5 from PR adobe#92 smoke test.

* feat(aem-design): briefings default to structured shape with [TBD] placeholders

Previously the skill asked the user to pick a fidelity level (prompt-only /
structured / full) before drafting. This created an unnecessary gate — the user
had to front-load a planning decision before they had any output to react to.

Now every briefing emits the same structured shape (Intent + Audience + Key
Messages + CTAs + Tone), with `[TBD]` written verbatim in sections the user
hasn't committed to. Downstream skills synthesize on-brand content for `[TBD]`
fields and stamp provenance. Fidelity becomes a consequence of how much the
user fills in, not a tier they select upfront.

- briefings/SKILL.md Phase 1: drop the fidelity question, default to structured,
  document [TBD] semantics. Phase 2: draft in structured shape always.
- briefing-format.md: replace three-tier fidelity table with structured+full
  shape table. Remove `fidelity` frontmatter field. Update Rules to require
  all five structured sections (with [TBD] valid as section body).
- evals/briefings-from-prompt: add `no_fidelity_gate` criterion (10), retune
  weights to keep total=100. Tighten briefing_sections and provenance_stamped
  descriptions. Rewrite task.md expected behavior.

Follow-up #6 from PR adobe#92 smoke test.

* feat(aem-design): prototype skill offers 1-4 variants to choose from

Early variant choice is cheaper than late iteration — committing silently to
one design direction means that changing direction after the user has asked
for type-scale tweaks throws away the tweaks. The soft-gate philosophy already
embraces "synthesize and stamp"; variants are the logical extension.

- prototype/SKILL.md Phase 0: ask "How many variants? (1-4, default 1)".
  N=1 preserves current behavior. N>=2 renders {page}-a.html, {page}-b.html, ...
  each exploring a load-bearing axis: type-voice, density, color-energy,
  imagery-role. Each variant's provenance block carries a `variant_direction`
  line.
- Phase 3 (Serve): for multi-variant, present a comparison table
  (direction / key visual move / risk) and ask the user which to take forward.
- Phase 4 (Iterate): iterate only on the chosen file. Unchosen variants stay
  on disk as design-history reference.
- Artifacts table documents both {page}.html and {page}-{letter}.html shapes.
- evals/prototype-iterate: add Scenario B (3 variants + choose B + iterate).
  New criteria: variant_count_asked (5), variant_directions_distinct (8),
  iteration_targets_chosen_variant (8). Retune existing weights to keep total=100.
  task.md extended with Scenario B expected behavior.

Follow-up #7 from PR adobe#92 smoke test (minimum ambition per plan).

* feat(aem-design/brand): add divergence toolkit and make reference-required the default

Push back against LLM-driven visual convergence across brand generations
by establishing three within-session mechanisms:

1. New _shared/divergence-toolkit.md (v0.1, self-audited) houses:
   - Default-moves budget (max 3 per profile) listing recurring LLM defaults
     across typography, motifs, voice rules, structure, and palette roles
   - Seed lists (decade x craft tradition x cultural register) used as hard
     constraints when no reference is provided; deterministic-random from
     MD5(brand-name + date) for audit reproducibility
   - Named font decks (editorial-archival, retro-italian, zine-maximalist,
     swiss-modernist, etc.) replacing ad-hoc font picks
   - Role-naming rule forbidding generic palette role slots
   - Reference-use discipline for listicle inputs (extract all trends, tag
     in/off-toolbox, require off-toolbox per variant)

2. brand/SKILL.md Phase 1: reference-required by default. Conversational
   input drops to option 4 (explicit escape hatch) with a verbatim warning
   citing the toolkit. When accepted, rolls a seed and stamps
   _divergence.divergence_warning=true.

3. brand/SKILL.md Phase 2: .impeccable.md authorship stamping. Every file
   opens with frontmatter declaring authored_by (designer|synthesized) and
   strength. Adds a "last chance" interview prompt before synthesis so
   downstream skills don't enforce LLM defaults as designer taste.

Schema additions in brand-profile-schema.md:
- New optional _divergence block as the second top-level key (captures
  seed, chassis, font_deck, anti_toolbox_count/hits, justifications,
  off_toolbox_moves, references_used with listicle tagging, warning flag)
- Role-naming enforcement on new writes; old profiles remain valid reads
- Optional sibling "use" field on color entries for technical qualifiers
  so role stays brand-native

Backward-compatible: missing _divergence block is valid; existing profiles
with generic role names are still read. No downstream skill is required
to hard-fail on these additions.

Addresses convergence observed when the same LLM regenerates brand boards
for unrelated categories (e.g., horror publisher vs. Italian pantry brand
sharing stencil typography, hazard stripes, rotated stamps, and identical
palette role taxonomies). See tmp/e2e-3 divergence report for analysis.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/brand): divergence toolkit v0.2 (I1+I2+I3+I5+I7)

Bundle five within-file edits to _shared/divergence-toolkit.md after a 4-run
test (e2e-4/5/6/7) surfaced specific gaps in v0.1. Changes:

I1 - Expanded § 1 Default-Moves List:
  - Added Triplet-cadence copy to Voice-rule moves (detected in all 4 test
    runs: "Same press. Same shop. Same eight years." / "Dated, classified,
    cross-linked." / "Saturday. Bar Beach. We dance.")
  - Added Collage-maximalism kit to Motif moves (the assistant's own
    archetype, reached for in fresh sessions without context)
  - Added Generic-2026-SaaS silhouette and Stat-callout bar to Structural
    moves (Linear/Notion/Stripe aesthetic; observed in Orrery run)
  - New Palette-family subsection covering the "archival editorial" palette
    that recurred in 3 of 4 test runs (cream ground + warm-family saturated
    accent + muted earth-tone secondary), cream-as-default page ground,
    brutalist-pomodoro, and dark-mode-editorial

I2 - Replaced the 3-free-hit budget with per-hit justification:
  - Every hit from § 1 now requires a brand-specific justification that
    would not transfer unchanged to an arbitrary other brand
  - Retired the budget because the 4-run test (Yadda Dey, 4 hits) showed
    the LLM comfortably fills it with defaults and rationalises excess

I3 - Moved sensible universal voice rules out of § 1 into new § 7:
  - Banned marketing adjectives list (artisanal/crafted/premium/curated/
    beloved/cozy/warm/inviting/thoughtfully/delightfully/lovingly/
    uncompromising/bespoke)
  - No exclamation points except italic quoted outbursts
  - Em-dashes welcome / semicolons earned
  These are opt-in house standards, copied into voice.rules[] when the
  brand or seed implies them, and do NOT count against the budget

I5 - Added new § 2.5 Dimension Weighting:
  - decade drives type deck + cultural references + display register
  - craft drives texture + motif idiom + print artifacts
  - register drives voice stance + structural metaphor + IA
  - Within-run variants use dimension dominance (A decade-lead, B craft-
    lead, C register-lead) to produce meaningful variant divergence
  - Added "Ground color by seed" table: cream belongs only to specific
    seeds (1920s-1960s x letterpress/riso/field-guide/travel-brochure);
    1990s x legal-contract belongs on pale gray; 1970s x enamel-sign
    belongs on saturated ground. Cream as default is now a § 1 hit.

I7 - Appended self-audit rationalisation check to Enforcement:
  - Hit audit: "would a reviewer agree this is a hit?" (A 'travel decal'
    that is a rotated circular stamp IS a rotated circular stamp)
  - Off-toolbox audit: is it a genuine invention or a dressed-up default?
  - Triplet-copy audit: max one triplet per page
  - Adjustments recorded in _divergence.audit_adjustments[]

Status banner updated to v0.2 - self-audited - run-tested with a v0.1 -> v0.2
changelog. Backward compatibility: _divergence.toolkit_version carries the
version so downstream skills can tell which list was in effect.

Addresses gaps surfaced in:
- /Users/paolo/excat/tmp/e2e-3/aem-design-divergence-test-assessment.md
- /Users/paolo/excat/tmp/e2e-3/aem-design-toolkit-v0.2-improvements.md

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/brand): tighten role-naming + remove cream default (I4+I8)

Close two palette-vocabulary loopholes observed in the 4-run test. Both
edits are small and compound with the divergence toolkit v0.2 shipped in
the previous commit.

I4 - brand-profile-schema.md Role Naming: token-level match

The v0.1 rule forbade specific values as the sole role name (Primary,
Secondary, Alarm, Warning, Shadow, Hardware, Accent, Background). That
string-equality check missed compound smuggling like "Accent Gold" /
"Primary Red" / "Brand Blue" — the generic taxonomy sneaks in alongside a
color name and passes validation.

v0.2 upgrades to token-level whole-word case-insensitive match. Any role
value containing a token from the forbidden list is rejected, including
compounds. New tokens added to the list: Neutral, Brand, House.

- Forbidden on new writes: Primary, Secondary, Tertiary, Alarm, Warning,
  Danger, Shadow, Hardware, Ink, Accent, Background, Neutral, Brand, House
  (anywhere in the role value, not just as the whole value)
- Technical intent continues to live in the sibling 'use' field, which is
  allowed to contain the forbidden tokens
- The color's 'name' field is also unrestricted - a color called "Shadow
  of Pomodoro" is fine; the 'role' field is the one that must be brand-
  native

Existing profiles with generic role names remain valid reads. The rule
applies only to new writes.

I8 - brand-board-template.md: remove cream default substrate

The v0.1 template said: "Light background (#faf9f6 or similar warm
neutral) for the page body". That instruction drove cream backgrounds in
3 of 4 test runs regardless of whether the brand's seed called for cream.
Shita-gawa's seed was 1990s x Letterpress x Legal contract (pale gray
substrate per toolkit v0.2 section 2.5) and still landed on cream because
the template told it to.

v0.2 replaces the instruction with a brand-derived-ground rule that points
at the divergence toolkit's Palette-family moves (section 1) and Ground
color by seed table (section 2.5). Example seeds that want cream are
named inline; example seeds that should NOT default to cream are also
named. The dark-sections rule is softened: inversion happens only when
the brand's palette supports an ink-or-deeper-than-ground surface, not as
a blanket template default.

Addresses gaps identified in:
- /Users/paolo/excat/tmp/e2e-3/aem-design-divergence-test-assessment.md
- /Users/paolo/excat/tmp/e2e-3/aem-design-toolkit-v0.2-improvements.md (I4, I8)

Canonical test after both commits: a Shita-gawa re-run should either
produce a non-cream ground, or stamp _divergence.anti_toolbox_hits[] with
a "Cream/paper as default page ground" entry carrying a brand-specific
justification.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/brand): chassis library (I6)

Split brand-board-template.md into a data contract and a chassis library,
ship 4 chassis specs, and update brand/SKILL.md Phase 3 to pick a chassis
per run. This is the single-largest remaining convergence axis: v0.2
boards diverged in palette/type/motif but shared one skeleton. Chassis
addresses that.

New files (brand/reference/chassis/):

classic-archive.md - v0.1 default preserved as one option; numbered
  sections, sticky top nav, masthead with metadata stamp, horizontal
  grid. Appropriate for archival/institutional/editorial brands.
  Reference: Pentagram annual report, MacGuffin.

dashboard.md - fixed left sidebar, cards-as-widgets, meters / gauges /
  status chips. Appropriate for operational/tool brands and seeds with
  railway-timetable, broadcast-captioning, sports-scorecard,
  repair-manual, hospital-discharge registers. Reference: Linear admin,
  Bloomberg Terminal overview.

magazine.md - masthead with Vol/Issue/date, column text, pull quotes,
  drop caps, magazine department heads (FEATURE / ESSAY / LETTER).
  Appropriate for tabloid, memoir, auction-catalogue, travel-brochure
  registers. Reference: Apartamento, The Gentlewoman.

pinboard.md - no sticky nav, cluster-based spatial arrangement,
  handwritten labels, scrapbook overlap. Appropriate for zine register
  and collective/community/youth brands. Reference: La Palatine, Cy
  Twombly workbook. Carries explicit caveat that picking pinboard
  does NOT excuse hitting the Collage-maximalism kit from
  divergence-toolkit.md section 1 Motif moves.

Each chassis spec covers: intent, navigation, section order, hero shape,
eyebrow conventions, spacing rhythm, typography register, motif placement,
what it is NOT, and example references. Structural, not taste-prose.

Modified files:

brand/reference/brand-board-template.md - rewritten as a data contract
  (what must be rendered) plus a chassis picker section. Adds explicit
  chassis-selection rules with seed-informed preference table. Previous
  "Required Sections" block now a plain bullet data-contract list.

brand/SKILL.md Phase 3 - rewritten to pick a chassis before rendering:
  1) designer override, 2) byte[3] hash from seed.hash_input mod chassis
  count, 3) seed-preference override, 4) fallback to classic-archive.
  Records _divergence.chassis and _divergence.chassis_pick_reason.

brand/reference/brand-profile-schema.md - adds chassis_pick_reason field
  to the _divergence block. chassis field description expanded to name
  the four available chassis.

After this commit, chassis selection is auditable: _divergence.chassis
and _divergence.chassis_pick_reason tell a reviewer exactly which
chassis landed and why. The expected outcome on a 4-run test (same
brands as e2e-4/5/6/7) is at least 3 different chassis across the 4
boards — structural divergence, not just surface divergence.

Addresses Improvement I6 in:
- /Users/paolo/excat/tmp/e2e-3/aem-design-toolkit-v0.2-improvements.md

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(aem-design): chassis artifact-agnostic + prototype integration (v0.3)

v0.2 shipped chassis as brand-board-only. The chassis files mixed
presentation-pattern concerns (nav, hero pattern, spacing, type register)
with brand-board-specific concerns (section list naming Palette/
Typography/Voice/etc). Prototypes still rendered on a single implicit
chassis — the exact convergence problem v0.2 was supposed to address.

v0.3 refactors chassis into a shared library both brand and prototype
read, and adds a prototype chassis picker.

Structural changes:

1. Move chassis files from brand/reference/chassis/ to _shared/chassis/.
   The library is artifact-agnostic; both brand and prototype skills now
   reference it.

2. Refactor each of the four chassis files
   (classic-archive/dashboard/magazine/pinboard):
   - Remove "Section order" subsection (brand-board-specific)
   - Rename "Hero shape" to "Hero pattern" (shape, not content)
   - Rename "Motif placement" to "Demo / visual presentation style"
     (applies to any demos, not just motifs)
   - Add explicit "this chassis describes a presentation pattern only"
     clarification at the top
   - Bump version 0.1 → 0.2, add scope: artifact-agnostic

3. brand-board-template.md:
   - Add "Section order per chassis (board-specific application)" block
     that maps the data contract to each chassis (this is where the
     brand-board-specific section order lives now)
   - Update chassis links from brand/reference/chassis/ to
     ../../_shared/chassis/
   - Renumber the Template Generation steps to accommodate the added
     section-order-reading step

4. prototype/reference/design-guide.md:
   - Add introductory paragraph about the shared chassis library
   - Add new "Chassis selection" section: designer override via
     _divergence.prototype_chassis → inherit from brand's
     _divergence.chassis → fallback classic-archive
   - Add "Prototype section order per chassis" table with per-chassis
     landing-page section ordering (e.g. dashboard landing: hero cluster
     → feature grid → status strip → reservation card → FAQ tray)
   - Add cross-chassis rules: one primary CTA, briefing drives content
     selection, motifs/components applied within sections per chassis
     demo style, variants stay within the chosen chassis

5. prototype/SKILL.md Phase 2:
   - Add Step A "Pick the chassis" before the render step
   - Chassis recorded in the prototype's provenance block with
     chassis_pick_reason
   - Step B renamed, includes "Apply the chassis's presentation pattern"

6. brand-profile-schema.md:
   - chassis field description updated to note prototypes inherit by
     default and to point at the new _shared/chassis/ location
   - New optional prototype_chassis field for per-artifact override

7. brand/SKILL.md Phase 3:
   - Path references updated from reference/chassis/ to
     ../_shared/chassis/
   - Clarified split: chassis spec is artifact-agnostic; section order
     lives in brand-board-template.md

Result: a brand on magazine chassis produces a brand board AND a
prototype both in magazine presentation pattern by default. Designer
can override prototype_chassis when a given brand wants one chassis for
internal documentation and another for public landing.

Addresses the "chassis was brand-board-only" gap raised in review.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/brand): swap pinboard for broadcast-grid chassis (v0.4)

Replace the pinboard chassis with broadcast-grid after review of v0.3's
4 chassis and 7 speculative mocks (see tmp/e2e-3/chassis-mocks/).

Rationale:

- Pinboard paired structurally with the Collage-maximalism kit listed in
  _shared/divergence-toolkit.md section 1. The chassis itself wasn't the
  problem (spatial cluster arrangement is a legitimate pattern), but in
  practice picking pinboard produced boards that then hit the anti-
  toolbox with rubber stamps, handwritten annotations, rotated date-
  blocks, and ripped edges. The chassis's very availability nudged the
  LLM toward its own "collage-maximalism" archetype — exactly the
  convergence the divergence work is trying to address.

- Broadcast-grid fills a structural gap that pinboard didn't. v0.3's
  4 chassis left no good home for brands whose seed register is
  railway-timetable, broadcast-captioning, sports-scorecard, liturgical-
  program, or pharmacy-insert — registers where the native form is a
  scoreboard / terminal / timetable. Dashboard was the fallback, but
  dashboard is cards-on-a-canvas; broadcast-grid is flat dense panes
  with a ticker. Different metaphor, different density.

Changes:

New: _shared/chassis/broadcast-grid.md (90 lines)
  - Intent: terminal / EPG / news-broadcast presentation
  - Navigation: top bar (channel + LIVE + tabs + clock) + ticker band
  - Hero pattern: multi-pane grid with 1.5fr hero pane + feed panes
  - Eyebrow conventions: pane title + source label, split by hairline
  - Spacing rhythm: 1px inter-pane rules, no radii, tight 14-16px pad
  - Typography: monospace-dominant, tabular numerals, condensed sans
    for pane titles; dark surface by default, light variant valid
  - Demo style: each demo rendered as a live-feed pane (table/list +
    source label), not as individual cards on a canvas
  - Explicit NOT list vs dashboard / classic-archive / magazine
  - Accessibility note on high-density contrast requirements

Removed: _shared/chassis/pinboard.md

Updated chassis selection and section orders:

brand/reference/brand-board-template.md:
  - Chassis list now alphabetical: broadcast-grid, classic-archive,
    dashboard, magazine
  - Hash-based default mapping updated: 0 -> broadcast-grid, 1 ->
    classic-archive, 2 -> dashboard, 3 -> magazine
  - Seed-informed preference table rewritten:
    - railway-timetable / broadcast-captioning / sports-scorecard /
      liturgical-program / pharmacy-insert -> broadcast-grid OR
      dashboard
    - zine register moved to magazine (was pinboard in v0.3)
    - legal-contract / repair-manual / museum-didactic / hospital-
      discharge still -> classic-archive OR dashboard (pharmacy-insert
      moved out)
  - Board section order per chassis: added broadcast-grid row (panes
    in a flat grid with a ticker above), removed pinboard row
  - Added note explaining why pinboard was retired — signal to propose
    a new chassis if zine brands need a non-magazine pattern, not to
    reintroduce pinboard

prototype/reference/design-guide.md:
  - Chassis list updated alphabetically with broadcast-grid
  - Prototype section order per chassis: added broadcast-grid (top bar
    + ticker + hero pane + feed panes + wide event pane + status strip
    + compact footer), removed pinboard
  - Cross-chassis rules: CTA-placement guidance for broadcast-grid
    hero pane; motif placement note includes live-feed panes

brand/SKILL.md Phase 3:
  - Hash mapping reference updated to new alphabetical order

brand/reference/brand-profile-schema.md:
  - chassis value domain updated: 'broadcast-grid' | 'classic-archive'
    | 'dashboard' | 'magazine'. Note added about v0.3 having pinboard
    and v0.4 routing zine to magazine

Chassis NOT-lists in the three preserved chassis updated:
  - Replaced "Not a pinboard" line with "Not a broadcast-grid" where
    useful (classic-archive, dashboard, magazine)

After v0.4: 4 chassis, zero anti-toolbox entanglement at the chassis
level, coverage of data-register brands that previously had no good
structural home.

Reference mocks for all four chassis in this repo at
tmp/e2e-3/chassis-mocks/{1-classic-archive,2-dashboard,3-magazine,
5-broadcast-grid}.html.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* revert(aem-design/brand): remove chassis system entirely (v0.5)

Chassis added in v0.3 and refined in v0.4 (chassis-library shared between
brand and prototype, 4 chassis with seed-preference routing) turned out to
be a distraction. In the e2e-8/9/10 test runs the chassis did pick
deterministically and the boards did render in their chosen chassis's
pattern, but the divergence payoff was marginal relative to the surface
area of the system — and the cream-ground convergence (the actual tell)
happened regardless of which chassis rendered.

Removed:

- _shared/chassis/broadcast-grid.md · classic-archive.md · dashboard.md ·
  magazine.md (entire chassis library)

Reverted to pre-chassis state:

- brand/reference/brand-board-template.md — back to a single canonical
  data contract with section order, design guidelines, and template
  generation steps. The cream-rebrand ban (vellum, kami, bone, ivory,
  eggshell) is preserved in the Design guidelines section.

- brand/SKILL.md Phase 3 — back to a single render step (read profile →
  generate HTML → write file → tell designer), no chassis pick, no
  pick-reason logging. Keeps the explicit "do not default to cream" line
  that points at toolkit §2.5.

- prototype/SKILL.md Phase 2 — removed Step A (chassis pick + provenance
  block stamping). Phase 2 is now a single render step.

- prototype/reference/design-guide.md — removed "Chassis selection" and
  "Prototype section order per chassis" sections. Replaced the
  "Cross-chassis rules" block with a "Landing-page section rules" block
  that holds the same invariants (one primary CTA, briefing drives
  content, motifs applied within sections, variants share copy + tokens).

- brand/reference/brand-profile-schema.md — removed chassis,
  chassis_pick_reason, and prototype_chassis fields from the _divergence
  block. Also removed the chassis bullet from the Divergence Tracking
  notes.

What remains from v0.3/v0.4:

- _shared/chassis/ directory deleted, but the structural reasoning (data
  contract vs presentation) has been absorbed into brand-board-template.md
  as a straightforward single-template spec.

- Font decks (toolkit §3) remain — they were always artifact-agnostic and
  drive real divergence.

- Seed system (§2 decade × craft × register) remains. The 'zine register
  route-to-magazine' routing is moot now that chassis routing is gone.

What this does not fix:

- Cream ground dominance observed in e2e-8 (justified by seed Embossed
  leather × Liturgical program), e2e-9 (cream rebranded as "kami" to slip
  the explicit ban), e2e-10 (cream justified by §2.5 carveout). The
  toolkit §2.5 Ground-color-by-seed table is the loophole — addressed in
  the next commit.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/brand): 4th seed dimension + cream rebrand ban (v0.5)

Second v0.5 change. Addresses the cream-ground convergence observed
across all three e2e-8/9/10 test runs:

- e2e-8 (Beumer & Becker, seed Embossed leather × Liturgical program) →
  cream justified by §2.5 carveout as "liturgical programs print on
  cream stock"
- e2e-9 (Shita-gawa, explicit cream ban in anti-toolbox) → cream
  rebranded as "kami" (Japanese paper) to slip the ban
- e2e-10 (Yadda Dey, seed 1960s × folded-paper × travel brochure,
  cream on §2.5 "belongs here" row) → cream permitted

All three grounds landed at #EDE.../#F0E.../#F5E... — clear cream family.

Two changes:

1. Expanded § 1 cream-family entry with rebrand ban and deterministic
   hex test:

   - Named rebrands called out: vellum, kami, parchment, washi, bone,
     oatmeal, eggshell, ivory, biscuit, tan, wheat, fawn, sand, linen,
     canvas, manila, calfskin, morocco-cream. Renaming cream does not
     change what it is.
   - Deterministic HSL-range test: a ground is cream-family when
     L is 80-97 AND (H is 20°-60° OR S < 15%) AND S < 40%. The LLM
     can perform this check on its own emitted hex before finalising.
   - Justification bar narrowed: cream is only acceptable when the
     brand's primary business is literally printing / publishing /
     paper-goods / binding / stationery. Adjacent registers
     (liturgical program, field guide, museum didactic, auction
     catalogue, travel brochure) are NOT sufficient on their own —
     they must combine with the brand being in that category.

2. Retired § 2.5 "Ground color by seed" table and replaced it with a
   new 4th seed dimension:

   - Ground family · deterministic-random from byte[3] of the seed
     hash mod 6: cream · stark-white · pale-gray · saturated · dark ·
     monochrome-tint
   - Stamped in _divergence.seed.ground with seed.picked_by and
     seed.overrides[] for mixed designer/auto picks
   - Cream now lands on ~1/6 of no-reference runs by construction,
     not by template default and not by LLM rationalisation
   - Designer override available for genuine print/paper brands

   The retired table was a carveout the LLM used to rationalise cream
   on most brands. Removing the opportunity for post-hoc rationalisation
   — by picking the ground BEFORE the LLM reasons about the brand —
   closes that specific loophole.

Schema updates:

- brand-profile-schema.md _divergence.seed now includes:
  - ground field (one of six enum values)
  - picked_by expanded to include 'mixed'
  - overrides array for mixed picks

- Status banner bumped to v0.5 with a v0.4→v0.5 changelog entry

Expected outcome on re-run of e2e-8/9/10 with same brand names/date:

- Each brand gets a specific hashed ground family. Cream shows up only
  when byte[3] mod 6 lands on 0.
- For brands that do not hash to cream, cream-family rebrands are
  actively prevented by the § 1 rebrand list + hex check.
- Shita-gawa's "kami" rebrand would now fail both the named-rebrand
  check AND the deterministic hex test.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(aem-design/brand): cream test uses raw channel warm-bias (v0.5.1)

v0.5 rule used 'S < 15' as a proxy for "warm or neutral" in the
cream-family hex test. That false-positively flagged pure neutral grays
as cream because grays satisfy S = 0. Observed in the Coolors-scraped
anchor library: the "Silver Lining" palette (#595959 #7F7F7F #A5A5A5
#CCCCCC #F2F2F2) got classified as cream despite being pure grayscale.

v0.5.1 replaces the saturation-as-proxy with raw-channel warm bias:
  R − B ≥ 5 in the raw 0-255 channels.

This still catches every legitimate cream rebrand from the v0.5 list
(vellum, kami, oatmeal, bone, eggshell, ivory, parchment, washi, biscuit,
tan, wheat, fawn, sand, linen, canvas, manila, calfskin) because those
ARE warm at low saturation — their R channel runs higher than their B
channel by design. It correctly excludes:
- #F5F5F5 (pure gray, R−B=0)
- #CCCCCC (pure gray, R−B=0)
- #D4E2E8 (cool gray, R<B)
- #E8ECEE (cool near-white, R<B)

Examples now include R−B deltas for each cream-family example so a
reviewer can verify the rule by eye.

Status banner bumped v0.5 → v0.5.1 with a short changelog entry.

Addresses issue observed when scraping Coolors trending and
classifying the 127 extracted palettes — see tmp/e2e-3/tools/
scrape-coolors.py which uses the same rule.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/brand): palette picker + library integration (v0.6)

Add an offline palette-selection phase to the brand skill. Replaces the
weakest link in the pipeline — LLM-invented color palettes — with a
pick-from-library flow whose colors come from real Coolors trending
palettes. Every hex carries a source URL back to coolors.co.

New files (127 palette JSONs + 4 structural files):

_shared/palettes/
  library.json                  consolidated index of all 127 entries
  cream/ (5)                    warm near-white grounds
  stark-white/ (6)              true-white, near-achromatic
  pale-gray/ (5)                cool near-neutral
  saturated/ (78)               bold, colored-light or colored-dominant
  dark/ (20)                    ink or deep-jewel grounds
  monochrome-tint/ (13)         tinted near-neutral with loud accent

  Each palette file: source URL, scraped_at, name, 5 hexes, classified
  anchor candidate, classification (ground_family + hue_bias +
  saturation_level + energy + cream-flag list). Scraped from
  coolors.co/palettes/trending on 2026-04-24 via tools/scrape-coolors.py
  in the session repo.

_shared/palette-picker.md       classifier vocabulary + filter scoring
  - §1 keyword dictionaries for 5 descriptor dimensions (energy,
    contrast, saturation_level, hue_bias, ground_family)
  - §2 filter scoring rules (exact/loose hue match, ±diff saturation +
    energy, ground-family 100-point match)
  - §3 HSL + raw-channel warm-bias helpers (for library regeneration)
  - §4 UI contract pointing at the template
  - §5 designer corrections section

brand/reference/pick-ui-template.md
  - full HTML template with {{placeholders}}
  - dark-background layout, numbered cards 1-5, gold border on
    recommended pick, cream-flag indicator per swatch, Coolors source
    links, designer instruction footer

Modified:

brand/SKILL.md
  - NEW Phase 2 Palette Selection (119 lines)
    Step A  derive description from designer brief OR synthesize from
            voice/pillars/seed
    Step B  classify via palette-picker.md §1 keyword vocabulary
    Step C  filter and score palettes/ per §2 rules
    Step D  render pick UI at aem-design/_palette-pick.html
    Step E  wait for designer pick (integer 1-5, palette name, or refine)
    Step F  record in in-memory profile + _divergence.palette_source
  - Renumbered downstream phases: Design Personality 2→3, Render Brand
    Board 3→4, Approval Gate 4→5
  - Updated "No .impeccable.md" cross-reference to point at Phase 3

brand/reference/brand-profile-schema.md
  - Added _divergence.palette_source object: method enum, library_version,
    description_used, classification block, candidates_shown array,
    recommended_index, picked_index, picked_palette_name,
    picked_palette_source
  - New "palette_source sub-block" doc section under Divergence Tracking
  - Backwards-compatible: older profiles without palette_source still
    read valid

Zero external dependencies. Entire flow runs offline from bundled data.

Expected outcome on a no-reference run:
- brand skill reaches Phase 2
- if designer provides a palette brief, runs classifier; else synthesizes
  one from voice + seed
- writes aem-design/_palette-pick.html with 5 candidate cards
- designer picks a number
- brand profile's colors.primary[] gets the Coolors hexes with
  brand-native role names from the designer (or derived if absent)
- _divergence.palette_source records the full chain for audit

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/prototype): Phase 0b imagery mode · generated or placeholder

Extend Phase 0 (previously "Variant Count") into "Setup" with a second
question: whether the prototypes should use branded placeholder
rectangles (default) or real generated images. When generated, the
skill collects the model name and credential source.

Changes:

prototype/SKILL.md Phase 0 renamed "Variant Count" → "Setup":
  - Step 0a (variant count) — existing content preserved
  - Step 0b (imagery mode) — NEW

Step 0b asks the designer:
  "For images in the prototype, do you want: (a) branded placeholder
   rectangles — fast, offline, free, or (b) real generated images?"

If (b), two follow-ups:
  1. Which model? Options presented with provider + env-var name:
     - gemini → Gemini 3 Pro Image Preview · GOOGLE_API_KEY
     - flux   → fal.ai FLUX Schnell        · FAL_KEY
     - imagen → Vertex Imagen 3            · GOOGLE_APPLICATION_CREDENTIALS
     - dalle  → OpenAI DALL-E 3            · OPENAI_API_KEY
  2. Where's the credential?
     - "env" → read from the named env var directly
     - A .env file path → read the var from that file (key stays in memory)
     - A raw token → used only for the session, not written to disk

Imagery mode recorded in each prototype's provenance block:
  <!-- aem-design:provenance
    imagery_mode: placeholder | generated
    imagery_provider: gemini | flux | imagen | dalle | null
    imagery_credential_source: "env" | "<file-path>" | "<session-only>"
    imagery_generated_at: <ISO timestamp> (only when mode=generated)
    images: [ { section, path, prompt_hash } ]
  -->

Never logs the actual key value anywhere. Re-ask-once logic: on subsequent
invocations in the same project, the skill reads the previous prototype's
provenance block and re-uses the recorded mode; only re-asks if missing.

Phase 2 consequences:
  - mode=placeholder → existing branded-rectangle path per design-guide.md
  - mode=generated   → invoke ai-image-generator skill (from eds-site-builder,
    sumi, or testing plugin — whichever is registered) with the briefing's
    # Imagery direction + brand photography rules + target aspect ratio.
    Images at aem-design/prototypes/images/{page}-{section}.png
  - Cache by prompt_hash — iteration doesn't re-generate unchanged prompts
  - Fallback when generation fails: retry once simplified, then fall back
    to placeholder for that slot only, stamp imagery_fallback: true, never
    abort the whole page over one failed image

design-guide.md Imagery section rewritten with three named paths:
  (a) briefing source hint — highest priority
  (b) branded placeholder (default)
  (c) generated image via ai-image-generator soft-dep

Alt-text requirement preserved across all three paths; "image" or "photo"
as the whole alt is explicitly disallowed.

Zero new dependencies. The generation path uses ai-image-generator which
is already available in the user's environment via three installed plugins.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(aem-design/prototype): default variant count 1 → 2, require confirm

Phase 0a used to default to 1 variant when the designer skipped. v0.7
changes the default to 2 (a pair to compare) and asks for explicit
confirmation:

  "I'll produce 2 variants of each prototype so you can compare — confirm,
   or give a different number (1-4)?"

Valid responses:
  - "ok" / "confirm" / "yes" / Enter / "2" → 2 variants (default)
  - 1 → single variant
  - 3 or 4 → that many variants
  - other → re-ask once

Rationale: the multi-variant comparison workflow (Phase 3 table, Phase 4
iteration on the chosen variant) is the more-useful default for design
decisions. A single variant skips the compare step; a pair captures the
most value for least effort.

Pipeline automation also defaults to 2 now — no explicit variant count
in the prompt means the skill renders 2 and presents them.

No downstream changes: Phase 2 rendering logic already handled both
single-variant and multi-variant modes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(stardust): rename aem-design plugin to stardust

Move from plugins/aem/design/ to plugins/stardust/ (top-level, sibling of
plugins/aem/, plugins/app-builder/, plugins/creative-cloud/). Rename
plugin identifier to "stardust". Rename content-folder convention
aem-design/ to stardust/ inside user projects. Broaden scope language
from AEM-EDS-specific to platform-agnostic static-HTML design.

No backward compatibility — clean break.

Filesystem moves (git mv, rename history preserved):
- plugins/aem/design/                       → plugins/stardust/
- plugins/stardust/skills/aem-design/       → plugins/stardust/skills/stardust/
- plugins/stardust/evals/aem-design-navigator/ → plugins/stardust/evals/stardust-navigator/

Manifest updates:
- .claude-plugin/marketplace.json — entry name aem-design → stardust,
  source path updated, description broadened to "static-HTML design
  projects" from "AEM Edge Delivery Services sites"
- plugins/stardust/.claude-plugin/plugin.json — name + description +
  keywords (removed aem, eds; added palette, wireframes)
- plugins/stardust/tile.json — adobe/aem-design → adobe/stardust, summary
  broadened, skill map key aem-design → stardust
- plugins/stardust/README.md — full rewrite with broadened scope,
  added "What makes stardust different" section covering the v0.2-v0.7
  palette library + divergence toolkit + seed system

Navigator skill (skills/stardust/SKILL.md):
- Frontmatter name aem-design → stardust
- Full prose rewrite via word-boundary sed

Source updates (single pass of \baem-design\b → stardust across all .md
and .json files in the plugin):
- ~60 invocation-path refs (/aem-design:* → /stardust:*)
- ~100 content-folder refs (aem-design/ → stardust/)
- ~20 prose mentions
- 1 eval-folder name ref

Scope-broadening edits (beyond the sed):
- prototype/SKILL.md description: "no EDS or dev-server dependency" →
  "no build system or dev-server dependency"
- prototype/SKILL.md: "EDS-free" → "platform-free", "EDS-independent"
  → "platform-independent"
- brand/SKILL.md icons/ note: reframed as "platform-agnostic" with EDS
  as one example
- wireframes-guide.md: "not an EDS block type" → "not a downstream
  block/component type"; "concrete EDS site" → "concrete site"

AEM/EDS still mentioned in scope-correct contexts as ONE EXAMPLE of a
downstream target (alongside "another SSG", "a different CMS", "a
framework component library") — those are kept. Eval criterion IDs
like "no_eds_references" kept stable so eval history still runs.

BREAKING: existing user projects with aem-design/ artifact folders are
not found by /stardust. Users must `mv aem-design stardust` in each
project. Installed plugin cache at
~/.claude/plugins/cache/adobe-skills/aem-design/0.1.0/ becomes stale;
re-install from the marketplace as stardust to replace.

Validation: all 5 skills valid under new paths. Zero remaining
aem-design references. Commit log preserves rename history via
git-mv + git similarity-detection.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(stardust): open HTML artifacts in browser after every write

Every HTML artifact the stardust skills produce now opens in the
designer's default browser immediately after it's written. No more
"tell the designer to open the file" wording — the skill invokes the
platform-appropriate open command via Bash.

Rule added to _shared/skill-contract.md:

  ## Opening HTML artifacts
  - macOS:   open "<absolute-path>"
  - Linux:   xdg-open "<absolute-path>" &
  - Windows: start "" "<absolute-path>"
  - Skill detects platform from environment, picks matching command.
  - Unknown platform → try open, fall back to xdg-open.
  - Open after EVERY write (including iteration re-writes).
  - Multi-variant mode: open all variants simultaneously for tab-
    compare.
  - Pipeline-automation mode (no designer present): skip the open.
  - Bash-unavailable environments: fall back to telling the designer
    the path.

Skill updates:

- brand/SKILL.md:
  - Phase 2 Step D (palette pick UI): `open stardust/_palette-pick.html`
    immediately after write. Designer message updated from "open the
    file" to "the UI is already open."
  - Phase 4 (brand board): `open stardust/brand-board.html` immediately
    after write. SLICC browser-panel path still works.

- wireframes/SKILL.md Phase 3 (Serve):
  - Open each emitted wireframe in the browser immediately.
  - Multi-page run: open each for tab-compare.
  - Old code-block with `open` + `xdg-open` side-by-side replaced with
    clear "skill does the open, not the designer" rule.

- prototype/SKILL.md Phase 3 (Serve):
  - Open each emitted prototype in the browser immediately after Phase 2
    render.
  - Multi-variant mode: open all variants simultaneously so the designer
    can flip between browser tabs for the comparison-table evaluation.
  - `python3 -m http.server` path preserved for cases that need a real
    HTTP origin (fetch/service-workers), but file:// via `open` is the
    primary path (covers ~95% of prototype needs).

- prototype/SKILL.md Phase 4 (Iterate):
  - Every iteration re-opens the file so the designer sees the change
    immediately. Browsers with live-reload pick up the change on
    re-open.

Rationale: the designer-opens-manually pattern added friction at every
gate. Phase 2 palette pick, Phase 4 brand board, wireframe review, and
prototype variant comparison all required the same mental gear-shift
of copy-path-then-open-browser. The open is one Bash call; putting it
in the skill removes a persistent small annoyance.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant