Skip to content

feat: add forms skill#6

Merged
vdua merged 18 commits into
mainfrom
forms
May 5, 2026
Merged

feat: add forms skill#6
vdua merged 18 commits into
mainfrom
forms

Conversation

@dmaurya929
Copy link
Copy Markdown

No description provided.

Anirudh Aggarwal and others added 17 commits April 9, 2026 11:10
AI-conversational plugin for building AEM Adaptive Forms on
Edge Delivery Services — from requirements to deployment.

Skills:
- Orchestrator gateway with phased request pipeline
- infra: setup-workspace, sync-forms, sync-eds-code, git-sandbox
- analysis: analyze-requirements, analyze-v1-form, create-screen-doc,
  review-screen-doc
- build: scaffold-form, create-form, create-component
- logic: add-rules, create-function, optimize-rules
- integration: manage-apis
- context: manage-context

CLI tools:
- Python: form-sync, eds-code-sync, git-sandbox, cct, api-manager,
  scaffold-form
- Node.js: rule-transform, rule-validate, rule-save, rule-grammar,
  parse-functions, form-validate

Includes post-phase checkpoint with deploy (AEM + EDS) and
report options, EDS deploy-and-resync lifecycle, and workspace
setup flow with credential collection and connectivity testing.
update

- Remove `form/` directory from workspace; forms now sync to `repo/`
- Update documentation and CLI help to match new structure
- Refactor `update_edge_delivery_config` to return detailed result dict
- Add remediation suggestions for common Edge Delivery config errors
- Improve error handling and messaging in CLI commands
…tries

Move all 6 domain skill trees (analysis, build, logic, integration,
infra, context) under references/domains/references/ and add domain
router SKILL.md files for each (type: domain). Add domain registry
(type: router) with assets: skills-catalog, phase-resolution,
contribution-guide, and domain-template.

Add pipeline registry (type: router) with assets: selection-rules,
plan-integration, contribution-guide, and pipeline-template. Add
build-journey pipeline definition (type: pipeline).

Add type field to all SKILL.md files:
- type: router for registries (domain-registry, pipeline-registry)
- type: domain for domain routers (analysis, build, logic, etc.)
- type: pipeline for pipeline definitions
- type: skill for all 16 leaf skills
…ssets/

Reduce orchestrator SKILL.md to a lean router (type: router, ~97 lines).
Offload heavy content to assets/:
- assets/routing-table.md (type: routing-table) — full routing algorithm
  with decision flow, dispatch tables, and precedence rules
- assets/guidelines.md (type: guidelines) — cross-cutting constraints,
  file locations, workspace resolution, and plan conventions

Follows the same offloading pattern now used by the domain and pipeline
registries.
Add docs/skill-architecture/ with 5 documents defining the architectural
patterns for multi-skill systems:

- README.md — architecture overview, skill type taxonomy (router, domain,
  pipeline, skill, routing-table, guidelines), type relationships, and
  layer recommendations by complexity
- skill-router-template.md (type: router) — template for dispatcher SKILL.md
- directory-structure.md (type: guidelines) — standard layouts (flat,
  grouped, deep) annotated with types at every level
- routing-table-template.md (type: routing-table) — template for offloaded
  routing logic
- guidelines-template.md (type: guidelines) — template for cross-cutting
  constraints

Update CONTRIBUTING.md with Skill Architecture subsection linking to all
templates.
Add the forms-orchestrator skill gateway with:
- SKILL.md: routing algorithm, registry references, quick reference
- assets/guidelines.md: orchestrator constraints, workspace resolution,
  plan conventions, script path resolution rules
- assets/routing-table.md: 6-step routing algorithm
- scripts/: all CLI tool entry points (eds-code-sync, form-sync,
  rule-transform, rule-validate, rule-save, rule-grammar, parse-functions,
  api-manager, git-sandbox) plus shared utilities (python3 wrapper,
  workspace resolver, setup script)
Add the domain registry router and all domain skill trees:
- Domain registry: SKILL.md, skills-catalog, skill-resolution,
  contribution guide, domain template
- analysis: analyze-requirements, analyze-v1-form, create-screen-doc,
  review-screen-doc
- build: scaffold-form, create-form, create-component
- logic: add-rules (with grammar reference, rule-types, examples),
  create-function, optimize-rules
- integration: manage-apis
- infra: setup-workspace, sync-forms, sync-eds-code, git-sandbox
- context: manage-context
Add the planner skill with:
- SKILL.md: strategy resolution, plan types, conventions
- assets/plan-template.md: standard plan file template
- references/default-strategy.md: workflow-based decomposition strategy
  with generic domain-agnostic examples
- references/structure-plan.md: form skeleton plan type
- references/workflow-plan.md: conditional branch plan type
- references/logic-plan.md: cross-cutting validation plan type
- references/integration-plan.md: API wiring plan type
- references/infrastructure-plan.md: error handling and session plan type

All examples use generic placeholders — no use-case-specific content.
…e scripts path

- Replace use-case-specific quick start example ('personal loan application')
  with generic phrasing
- Annotate scripts/ in repo structure tree to clarify it is accessed via
  CLAUDE_PLUGIN_ROOT/forms-orchestrator/scripts/
- Add Recent Fixes table covering eds-code-sync CI fixes, path resolution,
  guidelines, and planner generalization
Branch names containing / (e.g. feature/personal-details-plan04) produced
invalid AEM preview URLs. Now sanitize by replacing / with -- so the URL
is well-formed.
The architecture documentation previously only described static pipeline-based
workflows (type: pipeline). The actual Forms implementation uses a plan-driven
approach where a Planner (type: skill) dynamically generates plans from user
requirements. This commit updates all three architecture docs to reflect both
patterns:

- README.md: Add Plan-Driven Workflows section, update type tables to include
  plan-template/plan-type/strategy asset types, update architectural layers and
  type relationship diagrams, add planner pattern note, update Getting Started
- directory-structure.md: Add plans/ to per-skill layout, add plan-driven layout
  variant alongside pipeline layout, add plan-related conventions and anti-patterns
- skill-router-template.md: Update type table and notes to reference plan-driven
  workflows as alternative to pipelines
Pipelines (type: pipeline) were never used in the actual implementation.
The plan-driven approach fully replaces them. This commit removes all
pipeline references from the architecture docs:

- README.md: Remove pipeline type, examples, diagrams, templates, and
  relationship entries. Rewrite Plan-Driven Workflows as the primary
  pattern (not an alternative). Simplify Getting Started.
- directory-structure.md: Remove pipeline from type tables, layouts,
  conventions, and anti-patterns. Promote plan-driven layout as the
  primary deep layout.
- skill-router-template.md: Remove pipeline from type table and notes.
feat : added the build skills which missed due to conflict with python's
@dmaurya929 dmaurya929 requested a review from trieloff as a code owner April 28, 2026 07:18
Merge main (7576cdd) into forms branch — kept aem-forms and app-builder
plugin entries, combined CONTRIBUTING.md sections, and unified README
structure to reflect both plugins/ and skills/aem/forms/ layouts.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@dmaurya929
Copy link
Copy Markdown
Author

@ard1498 let me know if we are good to merge this PR in main or we need more time for testing.

@vdua vdua merged commit acfa5d5 into main May 5, 2026
7 checks passed
@vdua vdua mentioned this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants