Skip to content

Support versioning #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 8, 2025
Merged

Support versioning #1895

merged 14 commits into from
Apr 8, 2025

Conversation

afranken
Copy link
Member

@afranken afranken commented May 28, 2024

Description

Support versions in all APIs

Related Issue

Fixes #64

Tasks

  • I have signed the CLA.
  • I have written tests and verified that they fail without my change.

@afranken afranken self-assigned this May 29, 2024
@afranken afranken force-pushed the 64-support-versioning branch 2 times, most recently from 35188ac to 4e4b8d4 Compare May 30, 2024 21:51
@afranken afranken force-pushed the 64-support-versioning branch from 38a475e to 5790298 Compare June 9, 2024 22:50
@afranken afranken force-pushed the 64-support-versioning branch from c166973 to e753b5f Compare December 10, 2024 17:10
@afranken afranken force-pushed the 64-support-versioning branch 3 times, most recently from 121b22d to fb59d36 Compare December 19, 2024 22:32
@afranken afranken force-pushed the 64-support-versioning branch 3 times, most recently from 121f4bb to 0562641 Compare February 23, 2025 11:02
@afranken afranken force-pushed the 64-support-versioning branch 3 times, most recently from cdd5511 to eb29318 Compare March 9, 2025 21:33
@afranken afranken requested a review from Copilot April 3, 2025 12:57
Copilot

This comment was marked as outdated.

@afranken afranken requested a review from Copilot April 6, 2025 22:43
Copilot

This comment was marked as outdated.

@afranken afranken force-pushed the 64-support-versioning branch 2 times, most recently from c87be20 to 41d3fc3 Compare April 6, 2025 23:06
@afranken afranken requested a review from Copilot April 6, 2025 23:12
Copilot

This comment was marked as outdated.

@afranken afranken force-pushed the 64-support-versioning branch from 41d3fc3 to 8f372f6 Compare April 8, 2025 22:15
afranken and others added 8 commits April 9, 2025 00:18
Needs extensive testing, delete marker implementation.

Fixes #64
Not all aspects have been tested yet.

Fixes #64
AWS has deprecated SDK for Java v1, and will remove support EOY 2025.
S3Mock will remove usage of Java v1 early 2026.
Tested the ITs against S3, found a few unexpected behaviours, fixed
S3Mock to reflect actual S3 behaviour.

Fixes #64
@afranken afranken force-pushed the 64-support-versioning branch from 8f372f6 to f5324b0 Compare April 8, 2025 22:18
@afranken afranken requested a review from Copilot April 8, 2025 22:19
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 67 out of 70 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • build-config/src/main/resources/build-config/checkstyle.xml: Language not supported
  • integration-tests/pom.xml: Language not supported
  • server/pom.xml: Language not supported
Comments suppressed due to low confidence (2)

server/src/main/java/com/adobe/testing/s3mock/BucketController.java:517

  • The removal of the 'startAfter' and 'continuationToken' request parameters in the listObjectVersions endpoint may impact pagination support. Please confirm that the updated signature and corresponding call to bucketService.listVersions is intentional and that any associated pagination behavior is handled appropriately.
public ResponseEntity<ListVersionsResult> listObjectVersions(

integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/ListObjectVersionsV2IT.kt:65

  • [nitpick] The test asserts that the versionId is exactly the literal 'null' for non-version enabled buckets. Consider checking for a null or absent value instead of the literal string 'null' to make the test more robust if the API behavior changes.
.containsExactlyInAnyOrder(Tuple(version1, true), Tuple(version2, true))

@afranken afranken merged commit e41cb95 into main Apr 8, 2025
6 checks passed
@afranken afranken deleted the 64-support-versioning branch April 8, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support versioning
1 participant