You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This commit aligns Adaptive Form _cq_styleConfig selectors with authored markup and canvas theme expectations: scoped label/help, long-description paragraphs, richer tabs/wizard/list markers, file-input and T&C surfaces, v2 wizard/nav/RTL, removal of duplicate submit/reset/button help entries, optional disabled widget styling, and theme config updates so datetime, scribble, and file upload v4 participate in the form theme editor.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
The reason will be displayed to describe this comment to others. Learn more.
Spot-checked the new selectors against the actual HTL/CSS — most map cleanly to real DOM (__label-container, data-cmp-enabled, switch hide-labels classes, T&C modal subtree, etc.), and several pre-existing typos (cmp-adaptiveform-X__label-container:disabled missing the leading dot, .adaptiveform-switch__widget-label missing the cmp- prefix) are nicely fixed here. A few concerns inline. High-level: please add a short manual-test note to the description (theme-editor inspector tree for the affected component families + republish check) since this PR has no test changes and is content-only.
The reason will be displayed to describe this comment to others. Learn more.
[disabled="true"] is an attribute-value match, not the standard boolean [disabled]. This will only fire when the markup literally writes disabled="true". Please verify the review HTL emits the value (vs. just disabled) — otherwise this state never matches. Same comment applies to the second htmlDisabled block at line 165.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit aligns Adaptive Form _cq_styleConfig selectors with authored markup and canvas theme expectations: scoped label/help, long-description paragraphs, richer tabs/wizard/list markers, file-input and T&C surfaces, v2 wizard/nav/RTL, removal of duplicate submit/reset/button help entries, optional disabled widget styling, and theme config updates so datetime, scribble, and file upload v4 participate in the form theme editor.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: