Skip to content

Updating style selectors for theme editor CC#1851

Open
muskgupta wants to merge 2 commits intodevfrom
ThemeSelectors
Open

Updating style selectors for theme editor CC#1851
muskgupta wants to merge 2 commits intodevfrom
ThemeSelectors

Conversation

@muskgupta
Copy link
Copy Markdown
Member

@muskgupta muskgupta commented Apr 10, 2026

Description

This commit aligns Adaptive Form _cq_styleConfig selectors with authored markup and canvas theme expectations: scoped label/help, long-description paragraphs, richer tabs/wizard/list markers, file-input and T&C surfaces, v2 wizard/nav/RTL, removal of duplicate submit/reset/button help entries, optional disabled widget styling, and theme config updates so datetime, scribble, and file upload v4 participate in the form theme editor.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

1 similar comment
@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@muskgupta muskgupta requested a review from sakshi-arora1 April 20, 2026 10:30
Copy link
Copy Markdown
Contributor

@sakshi-arora1 sakshi-arora1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-checked the new selectors against the actual HTL/CSS — most map cleanly to real DOM (__label-container, data-cmp-enabled, switch hide-labels classes, T&C modal subtree, etc.), and several pre-existing typos (cmp-adaptiveform-X__label-container:disabled missing the leading dot, .adaptiveform-switch__widget-label missing the cmp- prefix) are nicely fixed here. A few concerns inline. High-level: please add a short manual-test note to the description (theme-editor inspector tree for the affected component families + republish check) since this PR has no test changes and is content-only.

<htmlDisabled
jcr:primaryType="nt:unstructured"
jcr:title="Disabled (HTML)"
cssSelector=".cmp-adaptiveform-review__edit-button[disabled=&quot;true&quot;]"/>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[disabled="true"] is an attribute-value match, not the standard boolean [disabled]. This will only fire when the markup literally writes disabled="true". Please verify the review HTL emits the value (vs. just disabled) — otherwise this state never matches. Same comment applies to the second htmlDisabled block at line 165.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this in latest commit to resolve it as [disabled]

@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

3 similar comments
@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

@adobe-bot
Copy link
Copy Markdown

Accessibility Violations Found

Id Impact
aria-required-attr critical
empty-heading minor
label-title-only serious
target-size serious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants