Skip to content

Fix: Hardcoded "Invalid Date" string in Generate Variations > prompt#316

Merged
audrey-kho merged 4 commits into
adobe:mainfrom
alp87488:SITES-25110
Mar 30, 2026
Merged

Fix: Hardcoded "Invalid Date" string in Generate Variations > prompt#316
audrey-kho merged 4 commits into
adobe:mainfrom
alp87488:SITES-25110

Conversation

@alp87488
Copy link
Copy Markdown
Contributor

@alp87488 alp87488 commented Oct 20, 2025

Description

  • Fix issue when date is displayed as "Invalid Date" when title contains numbers.
  • Use Intl.DateTimeFormat for correct date formatting
  • Localize "Empty" string
  • Fix incorrectly displayed RTL titles

Related Issue

https://jira.corp.adobe.com/browse/SITES-25110
https://jira.corp.adobe.com/browse/SITES-21944

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Copy Markdown
Collaborator

@audrey-kho audrey-kho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Collaborator

@sirgil2009 sirgil2009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing any obvious issues here. Looks good

@alp87488 alp87488 closed this Mar 6, 2026
@alp87488 alp87488 reopened this Mar 6, 2026
@audrey-kho audrey-kho merged commit a1fb207 into adobe:main Mar 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants