Skip to content

SITES-41121 Screen reader announces component name and an invisible group name #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StoianLucian merged 1 commit into from
Mar 17, 2026
Merged

SITES-41121 Screen reader announces component name and an invisible group name #406

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions coral-base-list/src/scripts/BaseList.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,11 @@ const BaseList = (superClass) => class extends superClass {
setIndex(element, value) {
if (element instanceof HTMLElement) {
element.setAttribute("tabindex", value);
const el = element.querySelectorAll("button:not([hidden])");
const buttonArray = Array.from(el).filter(item => item.offsetParent);
Copy link
Copy Markdown

@surajmall surajmall Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we use “offsetParent === null” as “treat as hidden / skip.”? are we sure that if offsetParent is null, does it means hidden?

Copy link
Copy Markdown
Contributor Author

@mariang-ens mariang-ens Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's basically the same logic as the one on line 205 (this.items._getSelectableItems().filter(item => !item.hasAttribute('hidden') && item.offsetParent);)
filter(el => el.offsetParent) = elements that are display:none, or in our case, which are hidden

buttonArray.forEach(item => {
item.setAttribute("tabindex", value);
});
}
}

Expand Down
Loading