Skip to content

fix(sheet): surface sign-in/permission errors instead of blank grid - #1335

Open
shsteimer wants to merge 8 commits into
mainfrom
sheetacc
Open

fix(sheet): surface sign-in/permission errors instead of blank grid#1335
shsteimer wants to merge 8 commits into
mainfrom
sheetacc

Conversation

@shsteimer

@shsteimer shsteimer commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Sheet editor previously fell back to an empty default sheet on any non-ok load response, so 401/403 (no access) looked identical to an empty sheet.
  • Adds a "Sign in required" / "Not permitted" message, mirroring canvas's showNotPermitted handling for the doc editor.
  • 404 is unaffected — still opens as a new, editable blank sheet (same as canvas treats a missing doc).
  • getData signals load status via sheet-load-error/sheet-load-ok document events rather than module-level state, matching the existing sheet-dirty/sheet-clean convention in utils/utils.js.

Fixes #1333

Preview: https://sheetacc--da-live--adobe.aem.live

Test plan

  • Open a sheet path you don't have access to → see "Not permitted" message instead of a blank grid
  • Open a sheet path while signed out → see "Sign in required"
  • Open a sheet path that doesn't exist yet (404) → still opens as an editable blank sheet
  • Open a normal, accessible sheet → unaffected

🤖 Generated with Claude Code

@shsteimer @claude
fix(sheet): surface sign-in/permission errors instead of blank grid
f1a0101 
getData silently fell back to an empty default sheet for any non-ok
response (401/403 included), so a no-access sheet looked identical to
an empty one. Mirrors canvas's not-permitted messaging; 404 still
falls through to an editable blank sheet.

Fixes #1333

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@aem-code-sync

aem-code-sync Bot commented Sep 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@shsteimer
shsteimer marked this pull request as ready for review September 14, 2026 18:27
@shsteimer @claude
test(sheet): lock in getLoadError behavior for 401/403/404
1a93010 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shsteimer @claude
refactor(sheet): signal load status via events, not module state
a4d48fb 
Module-level loadError plus threading a wrapper element through
setSheet/reloadSheet was awkward. getData now emits sheet-load-error /
sheet-load-ok on document, mirroring the existing sheet-dirty /
sheet-clean convention in utils/utils.js, and sheet.js listens once in
init() instead of passing a DOM node down the call chain.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shsteimer @claude
refactor(sheet): emitLoadStatus takes (success, message)
07c80d7 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shsteimer @claude
refactor(sheet): drop redundant success param, message alone is enough
a90b7dc 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shsteimer @claude
refactor(sheet): rename message to errMsg for clarity
d1c9323 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shsteimer shsteimer mentioned this pull request Sep 14, 2026
Closed
shsteimer and others added 2 commits September 14, 2026 11:43
@shsteimer @claude
docs(sheet): clarify version-preview error gap is unhandled, not covered
5ed522e 
Points at follow-up issue #1336 instead of implying da-version-review
already surfaces version-load failures elsewhere.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@shsteimer @claude
style(sheet): drop self-explanatory comment on emitLoadStatus
63ac9b2 
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
mhaack
mhaack approved these changes Sep 17, 2026
View reviewed changes

@mhaack mhaack left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhaack mhaack mhaack approved these changes
@hannessolo hannessolo Awaiting requested review from hannessolo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[EW] Sheet editor shows blank grid instead of a permission error

2 participants

@shsteimer @mhaack