fix: make a tag link draggable with usePress
#7448
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehm8128
commented
Nov 28, 2024
Comment on lines
+942
to
+944
| if (target.tagName === 'A' && target.getAttribute('draggable') !== 'false') { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
if target is a tag and doesn't have draggable="false" attr, we shouldn't prevent default to enable to drag the link
mehm8128
commented
Nov 28, 2024
| return false; | ||
| } | ||
|
|
||
| return !target.hasAttribute('draggable'); |
There was a problem hiding this comment.
Q: I think even if target element has draggable="false", target.hasAttribute('draggable') is true (because hasAttribute ignore its value), is it ok? or should we fix it to be !(target.getsAttribute('draggable') === "true");?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6618
I'm not sure this solution is proper to solve the issue so if there is some missing consideration please let me know 🙏
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: