Skip to content

fix: pass loadingState to useAsyncList's load function #7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: pass loadingState to useAsyncList's load function #7955

wants to merge 1 commit into from

Conversation

joshuajaco
Copy link
Contributor

The loadingState was typed but never passed

@joshuajaco
Copy link
Contributor Author

It looks like it was removed in #1829

devongovett
devongovett approved these changes Apr 12, 2025
View reviewed changes
Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LFDanLu I know it was a long time ago, but any memory why we removed it?

@LFDanLu
Copy link
Member

LFDanLu commented Apr 14, 2025

@devongovett it seems to be because of combobox bugs, specifically when triggering multiple loadMores and/or if a loadMore was triggered -> canceled via selecting an option -> triggered again when opening the ComboBox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshuajaco @LFDanLu @devongovett