Skip to content

fix(S2): inert value and img empty src string in React 19 #8359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 10, 2025
Merged

fix(S2): inert value and img empty src string in React 19 #8359

merged 5 commits into from
Jun 10, 2025

Conversation

reidbarber
Copy link
Member

@reidbarber reidbarber commented Jun 6, 2025 •
edited
Loading

  • Fixes CardView story formats
  • Fixes inert value error (for React 19) in Skeleton and RAC Tabs
  • Fixes empty src string error in Image

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Check S2 CardView and ActionBar stories and verify they render without issues.

🧢 Your Project:

@reidbarber reidbarber changed the title fix(S2): React 19 and storybook fixes: fix(S2): React 19 and storybook fixes Jun 6, 2025
@rspbot
Copy link

rspbot commented Jun 6, 2025

Build successful! 🎉

devongovett
devongovett reviewed Jun 6, 2025
View reviewed changes
@reidbarber reidbarber changed the title fix(S2): React 19 and storybook fixes fix(S2): inert value and img empty src string in React 19 Jun 9, 2025
@rspbot
Copy link

rspbot commented Jun 9, 2025

Build successful! 🎉

snowystinger
snowystinger previously approved these changes Jun 9, 2025
View reviewed changes
devongovett
devongovett previously approved these changes Jun 9, 2025
View reviewed changes
@snowystinger snowystinger dismissed stale reviews from devongovett and themself via d17690b June 9, 2025 23:38
@reidbarber reidbarber enabled auto-merge June 9, 2025 23:38
@rspbot
Copy link

rspbot commented Jun 9, 2025

Build successful! 🎉

@reidbarber reidbarber added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit 90f8432 Jun 10, 2025
30 checks passed
@reidbarber reidbarber deleted the s2-story-fixes branch June 10, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@devongovett devongovett devongovett left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@reidbarber @rspbot @devongovett @snowystinger @LFDanLu