-
Notifications
You must be signed in to change notification settings - Fork 1.3k
chore: Ts more explicit modules #8375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
snowystinger
wants to merge
8
commits into
main
Choose a base branch
from
ts-more-explicit-modules
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build successful! 🎉 |
Build successful! 🎉 |
Build successful! 🎉 |
devongovett
reviewed
Jun 11, 2025
Build successful! 🎉 |
devongovett
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes
Form stories is a 1:1 comparison to convert to CSF. All S2 icons/illustrations now have a return type of ReactNode, this should be correct for newer versions of React and is what we currently return https://app.unpkg.com/@react-spectrum/[email protected]/files/icons/3D.d.ts
All v3 icons now return JSX.Element, same as implicit https://app.unpkg.com/@spectrum-icons/[email protected]/files/123.d.ts
Made some files in dev/test-utils typescript so that i could explicitly type the source as opposed to casting where it was being used
To test, you can edit tsconfig. Note, there are still errors in the repo, this is a subset of the changes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: