docs: Style macro reference table refactor #9329
Conversation
|
Build successful! 🎉 |
|
Build successful! 🎉 |
LFDanLu
changed the title
| maxHeight: createSpectrumSizingProperty('maxHeight', (() => { | ||
| // auto is not a valid value for maxHeight | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const {auto, ...rest} = height; | ||
| return {...rest, none: 'none'}; | ||
| })()), |
There was a problem hiding this comment.
note this change in the theme, should be pretty minor
| 'colors': { | ||
| description: 'Transition property for color related properties: color, background-color, border-color, fill, and stroke.' | ||
| }, | ||
| 'opacity': { | ||
| description: 'Transition property for opacity.' | ||
| }, | ||
| 'shadow': { | ||
| description: 'Transition property for box-shadow.' |
There was a problem hiding this comment.
Should transition be transitionProperty? The name actually matches the short hand, so is the intent here actually that people would use the transition shorthand and transition isn't actually a property?
|
Build successful! 🎉 |
|
Build successful! 🎉 |
|
Is |
|
@devongovett my thought was that the shorthands should be listed inside every theme property that they map to since new users would be more likely to search for the CSS properties they are familiar with, and then they'd be able to discover the shorthand upon opening the disclosure for said property. If we had shorthands as a top level property in the reference, would we then not have the properties they map to as top level properties? |
|
also TODO: where to put this in the side bar, gets lost in components right now |
| export default Layout; | ||
|
|
||
| export const section = 'Components'; | ||
| export const section = 'Reference'; |
There was a problem hiding this comment.
Moved this to its own section, feel free to weigh in
|
Build successful! 🎉 |
|
Build successful! 🎉 |
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: