Skip to content

Conversation

@yihuiliao
Copy link
Member

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

devongovett
devongovett previously approved these changes Dec 11, 2025
@rspbot
Copy link

rspbot commented Dec 11, 2025

@rspbot
Copy link

rspbot commented Dec 11, 2025

@rspbot
Copy link

rspbot commented Dec 11, 2025

## API Changes

react-aria-components

/react-aria-components:TooltipTrigger

 TooltipTrigger {
   children: ReactNode
   closeDelay?: number = 500
-  closeOnPress?: boolean = true
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   onOpenChange?: (boolean) => void
+  shouldCloseOnPress?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

/react-aria-components:TooltipTriggerComponentProps

 TooltipTriggerComponentProps {
   children: ReactNode
   closeDelay?: number = 500
-  closeOnPress?: boolean = true
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   onOpenChange?: (boolean) => void
+  shouldCloseOnPress?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

@react-aria/tooltip

/@react-aria/tooltip:TooltipTriggerProps

 TooltipTriggerProps {
   closeDelay?: number = 500
-  closeOnPress?: boolean = true
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   onOpenChange?: (boolean) => void
+  shouldCloseOnPress?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

@react-spectrum/s2

/@react-spectrum/s2:TooltipTrigger

 TooltipTrigger {
   children: ReactNode
-  closeOnPress?: boolean = true
   containerPadding?: number = 12
   crossOffset?: number = 0
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   onOpenChange?: (boolean) => void
   placement?: 'start' | 'end' | 'right' | 'left' | 'top' | 'bottom' = 'top'
+  shouldCloseOnPress?: boolean = true
   shouldFlip?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

/@react-spectrum/s2:TooltipTriggerProps

 TooltipTriggerProps {
   children: ReactNode
   closeDelay?: number = 500
-  closeOnPress?: boolean = true
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   onOpenChange?: (boolean) => void
+  shouldCloseOnPress?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

@react-spectrum/tooltip

/@react-spectrum/tooltip:TooltipTrigger

 TooltipTrigger {
   children: [ReactElement, ReactElement]
-  closeOnPress?: boolean = true
   containerPadding?: number = 12
   crossOffset?: number = 0
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   offset?: number = 7
   onOpenChange?: (boolean) => void
   placement?: Placement = 'top'
+  shouldCloseOnPress?: boolean = true
   shouldFlip?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

/@react-spectrum/tooltip:SpectrumTooltipTriggerProps

 SpectrumTooltipTriggerProps {
   children: [ReactElement, ReactElement]
-  closeOnPress?: boolean = true
   containerPadding?: number = 12
   crossOffset?: number = 0
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   offset?: number = 7
   onOpenChange?: (boolean) => void
   placement?: Placement = 'top'
+  shouldCloseOnPress?: boolean = true
   shouldFlip?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

@react-stately/tooltip

/@react-stately/tooltip:TooltipTriggerProps

 TooltipTriggerProps {
   closeDelay?: number = 500
-  closeOnPress?: boolean = true
   defaultOpen?: boolean
   delay?: number = 1500
   isDisabled?: boolean
   isOpen?: boolean
   onOpenChange?: (boolean) => void
+  shouldCloseOnPress?: boolean = true
   trigger?: 'hover' | 'focus' = 'hover'
 }

@devongovett devongovett added this pull request to the merge queue Dec 11, 2025
Merged via the queue into main with commit 9493245 Dec 11, 2025
32 checks passed
@devongovett devongovett deleted the tooltip-shouldCloseOnPress branch December 11, 2025 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants