Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Dec 11, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Go to old docs, there shouldn't be a search bar at the top right anymore

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Dec 11, 2025

reidbarber
reidbarber previously approved these changes Dec 11, 2025
@reidbarber
Copy link
Member

I wonder if we should put the library logo + name in the nav bar on mobile now that there is room? Probably not a big priority.

@@ -1,337 +0,0 @@
import algoliasearch from 'algoliasearch/lite';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably remove from dependencies now?

import algoliasearch from 'algoliasearch/lite';
import docsStyle from './docs.css';
import DocumentOutline from '@spectrum-icons/workflow/DocumentOutline';
import DOMPurify from 'dompurify';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dependency

@rspbot
Copy link

rspbot commented Dec 11, 2025

@LFDanLu LFDanLu added this pull request to the merge queue Dec 12, 2025
Merged via the queue into main with commit 3d7bc7f Dec 12, 2025
32 checks passed
@LFDanLu LFDanLu deleted the remove_algolia branch December 12, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants