feat: string-compiler ESM support#9465
Merged
Merged
Conversation
snowystinger
approved these changes
Jan 13, 2026
snowystinger
left a comment
snowystinger
left a comment
Member
There was a problem hiding this comment.
Seems fine. Parcel does this for us when we build which is why we haven't had this as an issue. I think any user could do the same, but it seems like a nice thing to offer.
devongovett
approved these changes
Jan 14, 2026
yihuiliao
added
the
no testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While adopting
@internationalized/string-compilerin our component library to reduce dependencies, we ran into issues with the existing CJS output.This PR adds optional ESM output support to
compileStrings, defaulting to CommonJS for backward compatibility.