fix: onSelectionChange should not be called for tabs that are links

[snowystinger]

Closes #5252

Currently, not only is onSelectionChange called, but it's called with the previous value. This is due to a line in useSelectableItem which forces the selected key to be reset to the previous value.

When a tab is a link, it's not responsible for determing what the link does, any synchronization should be done by the user.

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

[snowystinger]

not thrilled with this prop, but I haven't figured out a better one that matches behaviour

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the S2 docs
• View the React Aria docs

[devongovett]

Why should onSelectionChange not be called? If the selectedKey is controlled it shouldn't affect anything anyway. Several other components also have linkBehavior: 'selection' so why is tabs different?

[snowystinger]

The issue is that links actually behave differently anyways and reset the selected key. That's what this is skipping. https://github.com/adobe/react-spectrum/pull/9967/changes#diff-daad97dc33ab4579bed0b1334d9e2acc3f563b18a8de0cbf20a65220f13ac3acR151

I can see an argument that skipping isn't quite right, but it also already doesn't cause selection due to

react-spectrum/packages/react-aria/src/selection/useSelectableItem.ts

Line 144 in ec7bc94

router.open(ref.current, e, itemProps.href, itemProps.routerOptions);

so onSelectionChange isn't what you should use to control selection when they are links. We mention this in our docs as well, that you should synchronise with the router instead and let the native link behaviour happen.

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the S2 docs
• View the React Aria docs

[rspbot]

## API Changes

@react-aria/selection

/@react-aria/selection:SelectableItemOptions

 SelectableItemOptions {
   allowsDifferentPressOrigin?: boolean
   focus?: () => void
   id?: string
   isDisabled?: boolean
   isVirtualized?: boolean
   key: Key
   linkBehavior?: 'action' | 'selection' | 'override' | 'none' = 'action'
   onAction?: () => void
   ref: RefObject<FocusableElement | null>
   selectionManager: MultipleSelectionManager
   shouldSelectOnPressUp?: boolean
+  shouldSkipResetSelection?: boolean = false
   shouldUseVirtualFocus?: boolean
 }

---

[rspbot]

Agent Skills Changes

Modified (2)

• react-aria/skills/react-aria/references/components/Tabs.md $\color{green}{+2}$
• s2/skills/react-spectrum-s2/references/react-aria/components/Tabs.md $\color{green}{+2}$

Install

React Spectrum S2:

npx skills add https://d1pzu54gtk2aed.cloudfront.net/pr/47afbf7dd439dab7a881b7cad1f193bd3366fac9/

React Aria:

npx skills add https://d5iwopk28bdhl.cloudfront.net/pr/47afbf7dd439dab7a881b7cad1f193bd3366fac9/