Feat/skill workflow launchers 65 lts#135
Open
akankshajain18 wants to merge 4 commits into
Open
Conversation
Updates the workflow-launchers skill for AEM 6.5 LTS with validated content covering launcher configuration, condition patterns, and JCR-event-driven workflow triggering. SKILL.md now references the canonical foundation refs hosted under workflow-orchestrator instead of local duplicates. - SKILL.md: expanded launcher configuration guidance; loop-prevention guardrail clarified (WorkflowSession vs JCR Session disambiguation); IDE-LLM consumability improvements; foundation ref links re-pointed to workflow-orchestrator canonical copies - condition-patterns.md: ECMAScript (Rhino) terminology corrected; pattern coverage tightened - launcher-config-reference.md: cq:WorkflowLauncher property reference expanded; consumability improvements Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…launchers (AEM 6.5 LTS) The 6 foundation reference files under workflow-launchers/references/ workflow-foundation/ duplicated the canonical copies hosted in workflow-orchestrator/references/workflow-foundation/. SKILL.md links were re-pointed to the canonical copies in the previous commit, so the local duplicates are now orphaned. Deletes: - 65-lts-guardrails.md - README.md - api-reference.md - architecture-overview.md - jcr-paths-reference.md - quick-start-guide.md Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…low-launchers (AEM 6.5 LTS)
The skill instructed setUserData("workflowmanager") for loop prevention.
AEM's WorkflowLauncherListener does not recognize that string. The
correct value is "changedByWorkflowProcess", which matches
HandlerBase.WORKFLOW_SESSION_USERDATA in
com.adobe.granite.workflow.core and is the default member of the OSGi
config property granite.workflow.launcher.globally.exluded.event.user.data
that the launcher reads at startup.
- SKILL.md: setUserData("workflowmanager") -> "changedByWorkflowProcess"
in the loop-prevention guardrail (2 occurrences in same line)
- condition-patterns.md: setUserData("workflowmanager") ->
"changedByWorkflowProcess" in the Java snippet; rewrote the comment
to correctly distinguish the OSGi config-property name from the
userData value
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…nd condition shorthand in workflow-launchers (AEM 6.5 LTS) Audit findings verified against AEM 6.5 LTS localhost:4505 OOTB launchers under /libs/settings/workflow/launcher/config/: - SKILL.md "Common OOTB Launchers" table: dam_update_asset_create does not exist (actual: update_asset_create); dam_update_asset_modify does not exist (actual: update_asset_mod); dam_xmp_writeback trigger description corrected to PROPERTY_CHANGED (eventType=16) on nt:unstructured at /jcr:content/metadata; update_page_version_* removed (not present in /libs, /conf, or /apps on a baseline 6.5 LTS install). Table expanded with eventType, nodetype, glob, and workflow columns - SKILL.md and launcher-config-reference.md: excludeList type corrected from String[] to String (single comma-separated value); description expanded to document the two entry formats — bare JCR property names and the event-user-data:<value> prefix that excludes events tagged with a specific JCR observation userData - launcher-config-reference.md: document the singular `condition` shorthand alongside the plural `conditions` array; both forms are accepted at startup - condition-patterns.md: loop-prevention comment rewritten to explain the changedByWorkflowProcess value via the customer-visible OSGi config property granite.workflow.launcher.globally.exluded.event. user.data (visible in Felix Console) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Tessl Skill Lint
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Audits and updates the AEM 6.5 LTS
workflow-launchersskill againstcq:WorkflowLauncherruntime behavior on AEM 6.5 LTS. Imports validated content for SKILL.md andpattern references, consolidates duplicated foundation refs to the canonical copies under
workflow-orchestrator, corrects a runtime-impacting loop-prevention bug, andaligns the OOTB Launchers catalog and
excludeListdocumentation with what/libs/settings/workflow/launcher/config/actually contains.Related Issue
Delete workflow-foundation as content was duplicate to workflow-launcher
Motivation and Context
The
workflow-launchersskill ships to customer IDEs as authoritative guidance for configuringcq:WorkflowLaunchernodes on AEM 6.5 LTS. Routine audit against a liveAEM 6.5 LTS instance surfaced four classes of issue in the prior content, each of which would lead a customer to a wrong configuration:
How Has This Been Tested?
Verified against AEM instance.
Screenshots (if appropriate):
Types of changes
Checklist: