Skip to content

Add app-builder cursor plugin metadata#137

Open
arjuncooliitr wants to merge 1 commit into
adobe:mainfrom
arjuncooliitr:main
Open

Add app-builder cursor plugin metadata#137
arjuncooliitr wants to merge 1 commit into
adobe:mainfrom
arjuncooliitr:main

Conversation

@arjuncooliitr
Copy link
Copy Markdown

Introduce a new cursor plugin metadata file at plugins/app-builder/.cursor-plugin/plugin.json describing the adobe-app-builder skill set (version 1.0.0-dev). Includes author, homepage, repository, Apache-2.0 license, and keywords covering project initialization, React Spectrum, testing (Jest, Playwright), and CI/CD deployment workflows.

Copy link
Copy Markdown
Contributor

@pru55e11 pru55e11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @arjuncooliitr — I picked this up to help unblock the failing checks. I don't have write access to adobe/skills, so I couldn't push the fix directly to your fork even though maintainerCanModify is on. Below is a summary of what I found, plus inline comments on the new file.


CI failures

1. conventional-commits (real failure, easy fix on your end)

Your commit message Add adobe-app-builder plugin metadata doesn't match the pattern ^(feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)(\([a-zA-Z0-9_-]+\))?!?: .+ enforced by .github/workflows/conventional-commits.yml. Suggested amend:

git commit --amend -m "feat: add adobe-app-builder plugin metadata" -m "Introduce a new cursor plugin metadata file at plugins/app-builder/.cursor-plugin/plugin.json describing the adobe-app-builder skill set (version 1.0.0-dev). Includes author, homepage, repository, Apache-2.0 license, and keywords covering project initialization, React Spectrum, testing (Jest, Playwright), and CI/CD deployment workflows."
git push --force-with-lease origin main

CONTRIBUTING.md also recommends npm run commit to generate a properly formatted message via wizard.

2. tessl-lint (pre-existing fork-PR infra issue, not a problem with your change)

The lint itself passedTotal: 2, Passed: 2, Failed: 0 with 8 pre-existing warnings on stardust files unrelated to this PR. The job exited 1 only on the final Creating new sticky comment step:

gh: Resource not accessible by integration (HTTP 403)
##[error]Process completed with exit code 1.

This is because .github/workflows/tessl-lint.yml uses the pull_request trigger, which gives forked PRs a read-only GITHUB_TOKEN regardless of the permissions: pull-requests: write block. The sticky-comment gh api -X POST then 403s. This will fail on every fork PR until the workflow is patched (e.g. wrap the gh api call so it doesn't fail the job, or switch to pull_request_target for the comment step). I'd suggest filing this as a separate issue — it's not yours to fix here.


Code-quality concerns on the new file

See inline comments. The biggest one: the .cursor-plugin/ directory introduces a brand-new convention to a repo that uses .claude-plugin/ everywhere (7 other plugins, the README's "Repository Structure" section, and the codeowners-coverage validator in validate.yml which only matches */.claude-plugin/plugin.json). And plugins/app-builder/.claude-plugin/plugin.json already exists for the same plugin, with a different name and version. Worth clarifying intent before merging.

Comment thread plugins/app-builder/.cursor-plugin/plugin.json
Comment thread plugins/app-builder/.cursor-plugin/plugin.json Outdated
Comment thread plugins/app-builder/.cursor-plugin/plugin.json Outdated
Add Cursor-native plugin manifest at plugins/app-builder/.cursor-plugin/plugin.json,
mirroring the existing .claude-plugin/plugin.json (name: app-builder, version: 1.0.0).

Documents the Cursor distribution channel in README under Installation, marking
app-builder as the pilot plugin. Other plugins will gain Cursor support once
the pattern is validated.
@arjuncooliitr
Copy link
Copy Markdown
Author

Thanks @pru55e11

Addressed review feedback:

  • Aligned name/version with .claude-plugin/plugin.json (app-builder, 1.0.0)
  • Added README "Cursor (preview)" section documenting app-builder as the pilot for Cursor distribution
  • conventional-commits compliant message (feat(app-builder): add cursor plugin metadata)

The tessl-lint failure is the pre-existing fork-PR sticky-comment 403 issue you flagged — leaving for a separate workflow patch as suggested.

@arjuncooliitr arjuncooliitr changed the title Add adobe-app-builder plugin metadata Add app-builder cursor plugin metadata May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants