Add app-builder cursor plugin metadata#137
Conversation
pru55e11
left a comment
There was a problem hiding this comment.
Hi @arjuncooliitr — I picked this up to help unblock the failing checks. I don't have write access to adobe/skills, so I couldn't push the fix directly to your fork even though maintainerCanModify is on. Below is a summary of what I found, plus inline comments on the new file.
CI failures
1. conventional-commits (real failure, easy fix on your end)
Your commit message Add adobe-app-builder plugin metadata doesn't match the pattern ^(feat|fix|docs|style|refactor|perf|test|build|ci|chore|revert)(\([a-zA-Z0-9_-]+\))?!?: .+ enforced by .github/workflows/conventional-commits.yml. Suggested amend:
git commit --amend -m "feat: add adobe-app-builder plugin metadata" -m "Introduce a new cursor plugin metadata file at plugins/app-builder/.cursor-plugin/plugin.json describing the adobe-app-builder skill set (version 1.0.0-dev). Includes author, homepage, repository, Apache-2.0 license, and keywords covering project initialization, React Spectrum, testing (Jest, Playwright), and CI/CD deployment workflows."
git push --force-with-lease origin mainCONTRIBUTING.md also recommends npm run commit to generate a properly formatted message via wizard.
2. tessl-lint (pre-existing fork-PR infra issue, not a problem with your change)
The lint itself passed — Total: 2, Passed: 2, Failed: 0 with 8 pre-existing warnings on stardust files unrelated to this PR. The job exited 1 only on the final Creating new sticky comment step:
gh: Resource not accessible by integration (HTTP 403)
##[error]Process completed with exit code 1.
This is because .github/workflows/tessl-lint.yml uses the pull_request trigger, which gives forked PRs a read-only GITHUB_TOKEN regardless of the permissions: pull-requests: write block. The sticky-comment gh api -X POST then 403s. This will fail on every fork PR until the workflow is patched (e.g. wrap the gh api call so it doesn't fail the job, or switch to pull_request_target for the comment step). I'd suggest filing this as a separate issue — it's not yours to fix here.
Code-quality concerns on the new file
See inline comments. The biggest one: the .cursor-plugin/ directory introduces a brand-new convention to a repo that uses .claude-plugin/ everywhere (7 other plugins, the README's "Repository Structure" section, and the codeowners-coverage validator in validate.yml which only matches */.claude-plugin/plugin.json). And plugins/app-builder/.claude-plugin/plugin.json already exists for the same plugin, with a different name and version. Worth clarifying intent before merging.
Add Cursor-native plugin manifest at plugins/app-builder/.cursor-plugin/plugin.json, mirroring the existing .claude-plugin/plugin.json (name: app-builder, version: 1.0.0). Documents the Cursor distribution channel in README under Installation, marking app-builder as the pilot plugin. Other plugins will gain Cursor support once the pattern is validated.
|
Thanks @pru55e11 Addressed review feedback:
The |
Introduce a new cursor plugin metadata file at plugins/app-builder/.cursor-plugin/plugin.json describing the adobe-app-builder skill set (version 1.0.0-dev). Includes author, homepage, repository, Apache-2.0 license, and keywords covering project initialization, React Spectrum, testing (Jest, Playwright), and CI/CD deployment workflows.