-
Notifications
You must be signed in to change notification settings - Fork 11
fix: add tokowaka auto-deploy api #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/routes/index.js
Outdated
| 'DELETE /sites/:siteId/opportunities/:opportunityId': opportunitiesController.removeOpportunity, | ||
| 'GET /sites/:siteId/opportunities/:opportunityId/suggestions': suggestionsController.getAllForOpportunity, | ||
| 'PATCH /sites/:siteId/opportunities/:opportunityId/suggestions/auto-fix': suggestionsController.autofixSuggestions, | ||
| 'PATCH /sites/:siteId/opportunities/:opportunityId/suggestions/tokowaka-deploy': suggestionsController.autoFixWithTokowaka, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer edgeDeploy over using tokowaka in APIs.
|
This PR will trigger a patch release when merged. |
package.json
Outdated
| }, | ||
| "devDependencies": { | ||
| "@adobe/eslint-config-helix": "3.0.12", | ||
| "@adobe/eslint-config-helix": "3.0.11", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason to downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was a previous package.json that I used to deploy on personal namespace. I have updated the latest package.json now.
| } | ||
| } | ||
|
|
||
| const response = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make sure these suggestion props are not overwritten by audit worker while updating the suggestions.
|
🎉 This PR is included in version 1.219.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Introduces a new API for deploying LLMO Opportunity suggestions on Edge (Project Tokowaka).
Implementation details are captured in https://wiki.corp.adobe.com/display/AEMSites/Tokowaka+-+Spacecat+Integration and https://wiki.corp.adobe.com/display/AEMSites/Tokowaka+Spacecat+Integration+-+Implementation+Internals.
Briefly, the API first fetches LLMO opportunity - Empty Headings for first iteration, generates a json patch config, uploads on S3, and invalidates the Tokowaka Cloudfront CDN cache.
The API is expected to be called from LLMO UI when the user clicks on deploy suggestion button.