fix: configuration shouldn't check for enabled if audit is enabledByDefault #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solaris007
reviewed
Apr 1, 2025
| if (handler.disabled) { | ||
| const sites = handler.disabled.sites || []; | ||
| const orgs = handler.disabled.orgs || []; | ||
| if (sites.includes(siteId) || orgs.includes(orgId)) { |
There was a problem hiding this comment.
this should be a direct return
There was a problem hiding this comment.
@solaris007
If we return directly, like earlier
return !(sites.includes(siteId) || orgs.includes(orgId));
we'll be returning just based on disabled only. If the site isn't disabled, or disabled is empty, we'll end up returning true. That's why I'm explicitly returning only if its specifically disabled or enabled or enabledByDefault.
solaris007
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the audit is enabled by default, Configuration.isHandlerEnabledForSite is checking if the configuration has enabled property, then checking in that list. If the audit is enabled by default, we shouldn't be checking the enabled list.
Fixes SITES-30390