fix: completionUrl not sent to content scraper and introduce skip property#685
Merged
fix: completionUrl not sent to content scraper and introduce skip property#685
Conversation
|
This PR will trigger a minor release when merged. |
dzehnder
changed the title
nitinja
approved these changes
Apr 15, 2025
solaris007
approved these changes
Apr 16, 2025
solaris007
pushed a commit
that referenced
this pull request
Apr 17, 2025
# [@adobe/spacecat-shared-data-access-v2.15.0](https://github.com/adobe/spacecat-shared/compare/@adobe/spacecat-shared-data-access-v2.14.1...@adobe/spacecat-shared-data-access-v2.15.0) (2025-04-17) ### Bug Fixes * completionUrl not sent to content scraper and introduce skip property ([#685](#685)) ([4d89a29](4d89a29)) ### Features * Add contentAiConfig validation to Config class ([#686](#686)) ([077fbbd](077fbbd))
Member
|
🎉 This PR is included in version @adobe/spacecat-shared-data-access-v2.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding missing
completionUrlso the audit worker can be triggered back after the scraper executes.Adding
allowCacheproperty for both the importer and scraper to return the already existing content instead of triggering an import/scrape again for every audit.