feat: add support for google CWV related APIs (PSI and CRUX) #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
shsteimer
commented
Jul 16, 2025
| @@ -32,6 +32,7 @@ export default class GoogleClient { | |||
| config.clientSecret, | |||
| config.redirectUri, | |||
| ); | |||
| this.apiKey = config.apiKey; | |||
There was a problem hiding this comment.
This may warrant a discussion if this is appropriate way to auth with these APIs or not.
My understanding is that the oath client used for the GSC apis that exist in this module uses OAUTH on behalf of the customer. In this case, I don't think we want to do that.
Both of these APIs support API key auth, subject to some rate limits. Would require us to create and manage that Key, but that I assume should be simple enough. But happy to discuss and if using oauth is the preferred route, it should be a simple change.
https://developers.google.com/speed/docs/insights/v5/get-started#APIKey
https://developer.chrome.com/docs/crux/api#crux_api_key
|
This PR will trigger a minor release when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!