Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: action button --mod-actionbutton-border-radius not getting picked up #5267

Closed
1 task done
SavkaTaras opened this issue Mar 27, 2025 · 1 comment · Fixed by adobe/spectrum-css#3644 · May be fixed by #5325
Closed
1 task done

[Bug]: action button --mod-actionbutton-border-radius not getting picked up #5267

SavkaTaras opened this issue Mar 27, 2025 · 1 comment · Fixed by adobe/spectrum-css#3644 · May be fixed by #5325
Labels
bug Something isn't working needs jira ticket triage An issue needing triage

Comments

@SavkaTaras
Copy link

SavkaTaras commented Mar 27, 2025

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

action-button

Expected behavior

Whenever setting --mod-actionbutton-border-radius css var at the host level it should override border-radius value.

Actual behavior

--mod-actionbutton-border-radius is not getting picked. This could be due to css var override with it's own name as a fallback or that it is missing as a border-radius value.

:host {
    border-radius: var(--mod-actionbutton-border-radius, var(--spectrum-actionbutton-border-radius));
}

See link.

Thank you

Screenshots

Image

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/action-button/
  2. Set --mod-actionbutton-border-radius to 999px and border radius will not be changed.

Sample code or abstract reproduction which illustrates the problem

No response

Severity

SEV 3

Logs taken while reproducing problem

No response

@tsavka-adobe
Copy link

Hello, this is still broken.

@castastrophe castastrophe linked a pull request Apr 4, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs jira ticket triage An issue needing triage
Projects
None yet
2 participants