Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency @spectrum-css/actionbutton to v7.1.3 #5325

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 3, 2025

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@spectrum-css/actionbutton (source) 7.1.2 -> 7.1.3 age adoption passing confidence

Release Notes

adobe/spectrum-css (@​spectrum-css/actionbutton)

v7.1.3

Compare Source

Patch Changes
  • #​3644 5adef1d Thanks @​marissahuysentruyt! - Fix support for --mod-actionbutton-border-radius to make sure it is surfaced to consumers, and properly overwrites the default border radius setting.

Configuration

📅 Schedule: Branch creation - "after 12pm on thursday" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the Spectrum CSS label Apr 3, 2025
@renovate renovate bot requested a review from a team as a code owner April 3, 2025 19:03
Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 4bdd18f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 84 packages
Name Type
@spectrum-web-components/action-button Patch
@spectrum-web-components/styles Patch
@spectrum-web-components/action-group Patch
@spectrum-web-components/action-menu Patch
@spectrum-web-components/combobox Patch
@spectrum-web-components/contextual-help Patch
@spectrum-web-components/menu Patch
@spectrum-web-components/overlay Patch
@spectrum-web-components/vrt-compare Patch
@spectrum-web-components/bundle Patch
@spectrum-web-components/card Patch
@spectrum-web-components/illustrated-message Patch
@spectrum-web-components/custom-vars-viewer Patch
example-project-rollup Patch
example-project-webpack Patch
@spectrum-web-components/theme Patch
@spectrum-web-components/truncated Patch
@spectrum-web-components/action-bar Patch
@spectrum-web-components/breadcrumbs Patch
@spectrum-web-components/picker Patch
@spectrum-web-components/story-decorator Patch
@spectrum-web-components/popover Patch
@spectrum-web-components/tooltip Patch
documentation Patch
@spectrum-web-components/slider Patch
@spectrum-web-components/eslint-plugin Patch
@spectrum-web-components/accordion Patch
@spectrum-web-components/alert-banner Patch
@spectrum-web-components/alert-dialog Patch
@spectrum-web-components/asset Patch
@spectrum-web-components/avatar Patch
@spectrum-web-components/badge Patch
@spectrum-web-components/button-group Patch
@spectrum-web-components/button Patch
@spectrum-web-components/checkbox Patch
@spectrum-web-components/clear-button Patch
@spectrum-web-components/close-button Patch
@spectrum-web-components/coachmark Patch
@spectrum-web-components/color-area Patch
@spectrum-web-components/color-field Patch
@spectrum-web-components/color-handle Patch
@spectrum-web-components/color-loupe Patch
@spectrum-web-components/color-slider Patch
@spectrum-web-components/color-wheel Patch
@spectrum-web-components/dialog Patch
@spectrum-web-components/divider Patch
@spectrum-web-components/dropzone Patch
@spectrum-web-components/field-group Patch
@spectrum-web-components/field-label Patch
@spectrum-web-components/help-text Patch
@spectrum-web-components/icon Patch
@spectrum-web-components/icons-ui Patch
@spectrum-web-components/icons-workflow Patch
@spectrum-web-components/icons Patch
@spectrum-web-components/iconset Patch
@spectrum-web-components/infield-button Patch
@spectrum-web-components/link Patch
@spectrum-web-components/meter Patch
@spectrum-web-components/modal Patch
@spectrum-web-components/number-field Patch
@spectrum-web-components/picker-button Patch
@spectrum-web-components/progress-bar Patch
@spectrum-web-components/progress-circle Patch
@spectrum-web-components/radio Patch
@spectrum-web-components/search Patch
@spectrum-web-components/sidenav Patch
@spectrum-web-components/split-view Patch
@spectrum-web-components/status-light Patch
@spectrum-web-components/swatch Patch
@spectrum-web-components/switch Patch
@spectrum-web-components/table Patch
@spectrum-web-components/tabs Patch
@spectrum-web-components/tags Patch
@spectrum-web-components/textfield Patch
@spectrum-web-components/thumbnail Patch
@spectrum-web-components/toast Patch
@spectrum-web-components/top-nav Patch
@spectrum-web-components/tray Patch
@spectrum-web-components/underlay Patch
@spectrum-web-components/base Patch
@spectrum-web-components/grid Patch
@spectrum-web-components/opacity-checkerboard Patch
@spectrum-web-components/reactive-controllers Patch
@spectrum-web-components/shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Apr 3, 2025

Branch preview

Review the following VRT differences

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Copy link

github-actions bot commented Apr 3, 2025

Tachometer results

Currently, no packages are changed by this PR...

@renovate renovate bot force-pushed the renovate/spectrum-css-actionbutton-7.x branch 5 times, most recently from ce34228 to c809ee2 Compare April 4, 2025 16:41
@castastrophe castastrophe force-pushed the renovate/spectrum-css-actionbutton-7.x branch 2 times, most recently from ca2e3fe to 7d16acd Compare April 4, 2025 16:44
Copy link
Contributor Author

renovate bot commented Apr 4, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@castastrophe castastrophe linked an issue Apr 4, 2025 that may be closed by this pull request
1 task
@castastrophe castastrophe force-pushed the renovate/spectrum-css-actionbutton-7.x branch 2 times, most recently from 688933c to d14fc94 Compare April 4, 2025 16:48
@castastrophe
Copy link
Collaborator

castastrophe commented Apr 4, 2025

Test case from original report [#3644]:

  • Set --mod-actionbutton-border-radius to 999px and border radius will not be changed.

Validated in Storybook for pull request.

Screenshot 2025-04-04 at 12 52 31 PM

Changes applied to component as expected.

Copy link
Contributor

@caseyisonit caseyisonit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- you can update the golden hash

@castastrophe
Copy link
Collaborator

LGTM -- you can update the golden hash

There's no visual regressions to update - the build right now had a flaky run but it should pass when I kick it back off.

@castastrophe castastrophe force-pushed the renovate/spectrum-css-actionbutton-7.x branch from d14fc94 to 7c56aa8 Compare April 4, 2025 17:54
@castastrophe castastrophe enabled auto-merge (rebase) April 4, 2025 17:55
@castastrophe castastrophe force-pushed the renovate/spectrum-css-actionbutton-7.x branch from 7c56aa8 to 4bdd18f Compare April 4, 2025 22:02
@castastrophe castastrophe force-pushed the renovate/spectrum-css-actionbutton-7.x branch from 4bdd18f to 9c19528 Compare April 4, 2025 22:35
@castastrophe castastrophe disabled auto-merge April 5, 2025 01:56
@castastrophe castastrophe enabled auto-merge (rebase) April 5, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: action button --mod-actionbutton-border-radius not getting picked up
4 participants