Skip to content

chore: update dependency @spectrum-css/actionbutton to v7.1.3 #5325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

chore: update dependency @spectrum-css/actionbutton to v7.1.3 #5325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9cb6af7
chore: update dependency @spectrum-css/actionbutton to v7.1.3
renovate[bot] Apr 4, 2025
c46d919
fix(action-button,styles): border-radius modifier patch
castastrophe Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/nine-geese-behave.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@spectrum-web-components/action-button': patch
'@spectrum-web-components/styles': patch
---

[#​3644](https://github.com/adobe/spectrum-css/pull/3644) Thanks [@​marissahuysentruyt](https://github.com/marissahuysentruyt)!

This patch update fixes support for `--mod-actionbutton-border-radius` to make sure it is accessible by consumers and overwrites the default border radius setting when used.
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ parameters:
# 3. Commit this change to the PR branch where the changes exist.
current_golden_images_hash:
type: string
default: be780955358effb497f871bc1ae942e092ffc75b
default: f0b3f3b4daf8fe12a6f13ff2e3b84dab31c76091
wireit_cache_name:
type: string
default: wireit
Expand Down
2 changes: 1 addition & 1 deletion packages/action-button/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"@spectrum-web-components/shared": "1.4.0"
},
"devDependencies": {
"@spectrum-css/actionbutton": "7.1.2"
"@spectrum-css/actionbutton": "7.1.3"
},
"types": "./src/index.d.ts",
"customElements": "custom-elements.json",
Expand Down
20 changes: 10 additions & 10 deletions packages/action-button/src/action-button-overrides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,32 +63,32 @@ governing permissions and limitations under the License.
}

:host {
--spectrum-actionbutton-border-radius: var(
--system-action-button-size-m-border-radius
--spectrum-actionbutton-border-radius-default: var(
--system-action-button-size-m-border-radius-default
);
}

:host([size='xs']) {
--spectrum-actionbutton-border-radius: var(
--system-action-button-size-xs-border-radius
--spectrum-actionbutton-border-radius-default: var(
--system-action-button-size-xs-border-radius-default
);
}

:host([size='s']) {
--spectrum-actionbutton-border-radius: var(
--system-action-button-size-s-border-radius
--spectrum-actionbutton-border-radius-default: var(
--system-action-button-size-s-border-radius-default
);
}

:host([size='l']) {
--spectrum-actionbutton-border-radius: var(
--system-action-button-size-l-border-radius
--spectrum-actionbutton-border-radius-default: var(
--system-action-button-size-l-border-radius-default
);
}

:host([size='xl']) {
--spectrum-actionbutton-border-radius: var(
--system-action-button-size-xl-border-radius
--spectrum-actionbutton-border-radius-default: var(
--system-action-button-size-xl-border-radius-default
);
}

Expand Down
3 changes: 1 addition & 2 deletions packages/action-button/src/spectrum-action-button.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ governing permissions and limitations under the License.
--spectrum-actionbutton-background-color: var(--highcontrast-actionbutton-background-color, var(--mod-actionbutton-background-color-default, var(--spectrum-actionbutton-background-color-default)));
--spectrum-actionbutton-border-color: var(--highcontrast-actionbutton-border-color, var(--mod-actionbutton-border-color-default, var(--spectrum-actionbutton-border-color-default)));
--spectrum-actionbutton-content-color: var(--highcontrast-actionbutton-content-color, var(--mod-actionbutton-content-color-default, var(--spectrum-neutral-content-color-default)));
--spectrum-actionbutton-border-radius: var(--mod-actionbutton-border-radius, var(--spectrum-actionbutton-border-radius));
--spectrum-actionbutton-border-radius: var(--mod-actionbutton-border-radius, var(--spectrum-actionbutton-border-radius-default));
--spectrum-actionbutton-border-width: var(--mod-actionbutton-border-width, var(--spectrum-border-width-100));
--spectrum-actionbutton-focus-indicator-gap: var(--mod-actionbutton-focus-indicator-gap, var(--spectrum-focus-indicator-gap));
--spectrum-actionbutton-focus-indicator-thickness: var(--mod-actionbutton-focus-indicator-thickness, var(--spectrum-focus-indicator-thickness));
Expand Down Expand Up @@ -315,7 +315,6 @@ governing permissions and limitations under the License.
line-height: var(--spectrum-actionbutton-height);
font-size: var(--spectrum-actionbutton-font-size);
white-space: nowrap;
color: inherit;
color: var(--mod-actionbutton-label-color, inherit);
text-overflow: ellipsis;
overflow: hidden;
Expand Down
10 changes: 5 additions & 5 deletions tools/styles/tokens-v2/system-theme-bridge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,19 +32,19 @@
--system-action-button-border-color-focus: transparent;
--system-action-button-border-color-disabled: transparent;
--system-action-button-content-color-selected: var(--spectrum-gray-50);
--system-action-button-size-m-border-radius: var(
--system-action-button-size-m-border-radius-default: var(
--spectrum-corner-radius-medium-size-medium
);
--system-action-button-size-xs-border-radius: var(
--system-action-button-size-xs-border-radius-default: var(
--spectrum-corner-radius-medium-size-extra-small
);
--system-action-button-size-s-border-radius: var(
--system-action-button-size-s-border-radius-default: var(
--spectrum-corner-radius-medium-size-small
);
--system-action-button-size-l-border-radius: var(
--system-action-button-size-l-border-radius-default: var(
--spectrum-corner-radius-medium-size-large
);
--system-action-button-size-xl-border-radius: var(
--system-action-button-size-xl-border-radius-default: var(
--spectrum-corner-radius-medium-size-extra-large
);
--system-action-button-quiet-background-color-default: transparent;
Expand Down
10 changes: 5 additions & 5 deletions tools/styles/tokens/express/system-theme-bridge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@
--system-action-button-border-color-focus: transparent;
--system-action-button-border-color-disabled: transparent;
--system-action-button-content-color-selected: var(--spectrum-gray-75);
--system-action-button-size-m-border-radius: var(
--system-action-button-size-m-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-xs-border-radius: var(
--system-action-button-size-xs-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-s-border-radius: var(
--system-action-button-size-s-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-l-border-radius: var(
--system-action-button-size-l-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-xl-border-radius: var(
--system-action-button-size-xl-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-quiet-background-color-default: transparent;
Expand Down
10 changes: 5 additions & 5 deletions tools/styles/tokens/spectrum/system-theme-bridge.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,19 +30,19 @@
--spectrum-disabled-border-color
);
--system-action-button-content-color-selected: var(--spectrum-gray-75);
--system-action-button-size-m-border-radius: var(
--system-action-button-size-m-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-xs-border-radius: var(
--system-action-button-size-xs-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-s-border-radius: var(
--system-action-button-size-s-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-l-border-radius: var(
--system-action-button-size-l-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-size-xl-border-radius: var(
--system-action-button-size-xl-border-radius-default: var(
--spectrum-corner-radius-100
);
--system-action-button-quiet-background-color-default: transparent;
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6814,9 +6814,9 @@ __metadata:
languageName: node
linkType: hard

"@spectrum-css/actionbutton@npm:7.1.2":
version: 7.1.2
resolution: "@spectrum-css/actionbutton@npm:7.1.2"
"@spectrum-css/actionbutton@npm:7.1.3":
version: 7.1.3
resolution: "@spectrum-css/actionbutton@npm:7.1.3"
peerDependencies:
"@spectrum-css/icon": ">=9.0.0 <10.0.0"
"@spectrum-css/tokens": ">=16.0.0 <17.0.0"
Expand All @@ -6825,7 +6825,7 @@ __metadata:
optional: true
"@spectrum-css/tokens":
optional: true
checksum: 10c0/f77bd14ac5cadf821ac6b0d0359550293d62caa52dfac1eb88182e6b2431f24c36664851f20ef6848394587e7481f8b897961d1cd9180e7f64a441be7768eab0
checksum: 10c0/21fea89ddf250145082ee8dd8d3837edd461f22879ded0d2b9dab1195bb845c8fabf7c497c0757b6a304338fcdb6d8be6dc1a95d71bebf09cd9f2bd27fde9216
languageName: node
linkType: hard

Expand Down Expand Up @@ -7886,7 +7886,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@spectrum-web-components/action-button@workspace:packages/action-button"
dependencies:
"@spectrum-css/actionbutton": "npm:7.1.2"
"@spectrum-css/actionbutton": "npm:7.1.3"
"@spectrum-web-components/base": "npm:1.4.0"
"@spectrum-web-components/button": "npm:1.4.0"
"@spectrum-web-components/icon": "npm:1.4.0"
Expand Down
Loading