fix(tabs): ensure tabs become enabled when parent disabled attribute is removed #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bb87c04 The changes in this PR will be included in the next version bump. This PR includes changesets to release 84 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Tachometer resultsCurrently, no packages are changed by this PR... |
mizgaionutalexandru
changed the title
|
@mizgaionutalexandru It looks like the styles for tabs aren't carrying through, I'll help investigate it |
|
Looks like it was a bad build in the check, PR links look accurate now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
focusInIndexmethod of the sp-tabs'RovingTabindexControllerin order to correctly find the element that should be focused even when the disabled property gets changed fromtruetofalse(or gets removed).Related issue(s)
Motivation and context
This change now allows the
focusElementto return the selected tab instead ofthis, which in turn allowsfocusable.ts'shandleDisabledChangedmethod to set thedisabledproperty of the selected tab tofalse.How has this been tested?
Test case 1
disabledandaria-disabledattributesdisabledattribute (or set it tofalseby using$0.disabled = false)disabledandaria-disabledattributes are no longer present, for both the sp-tabs and the selected tabDid it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Before:
After:
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.