Skip to content

chore(badge): add vrt support - #6591

Open
cdransf wants to merge 1 commit into
mainfrom
cdransf/badge-vrt-coverage
Open

chore(badge): add vrt support#6591
cdransf wants to merge 1 commit into
mainfrom
cdransf/badge-vrt-coverage

Conversation

@cdransf

@cdransf cdransf commented Aug 6, 2026

Copy link
Copy Markdown
Member

Description

Adds badge.vrt.ts and badge-custom-properties.vrt.ts under badge/test/vrt/: all semantic/non-semantic variants x size, outline, subtle, fixed positioning, icon anatomy, forced-colors, and all 17 custom properties.

Motivation and context

Extends the VRT foundation (button/link/divider/avatar) to Badge.

Related issue(s)

  • fixes SWC-2397

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed the Accessibility Practices for this feature.
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Accessibility testing checklist

  • Keyboard: N/A — Badge is non-interactive and not focusable; no keyboard behavior to test.
  • Screen reader: 1. Open Storybook → Badge → Badge VRT. 2. Confirm no console errors/warnings on load. 3. Spot-check one badge per variant row and the icon-only cases with a screen reader; expect label text (or aria-label for icon-only) announced, no extra noise.

@cdransf cdransf self-assigned this Aug 6, 2026
@cdransf
cdransf requested a review from a team as a code owner August 6, 2026 19:39
@cdransf cdransf added Component:Badge Spectrum 2 Issues related to Spectrum 2 run_vrt Triggers the Chromatic VRT run for 2nd-gen labels Aug 6, 2026
@changeset-bot

changeset-bot Bot commented Aug 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4d3c7de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rubencarvalho

Copy link
Copy Markdown
Contributor

No strong opinion, but would it be worth it to also have at least one outline variant permutating its size?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:Badge run_vrt Triggers the Chromatic VRT run for 2nd-gen Spectrum 2 Issues related to Spectrum 2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants