Skip to content

chore(progress-circle): add vrt support - #6600

Open
cdransf wants to merge 1 commit into
mainfrom
cdransf/progress-circle-vrt-coverage
Open

chore(progress-circle): add vrt support#6600
cdransf wants to merge 1 commit into
mainfrom
cdransf/progress-circle-vrt-coverage

Conversation

@cdransf

@cdransf cdransf commented Aug 10, 2026

Copy link
Copy Markdown
Member

Description

Adds Storybook VRT coverage for progress-circle: independent size and state rows (indeterminate, 0/25/50/75/100 determinate, one labeled row per state so indeterminate can't collide visually with a determinate value), static-color states on contrast backgrounds, forced-colors, and custom-property reference/override rows; test-only, no runtime code changes.

Motivation and context

SWC-2412 requires VRT coverage for progress-circle following the button/divider/card/meter VRT foundation (#6463); no global-styles VRT file since the component has no plain-element equivalent, and no reduced-motion story since no existing tooling in this repo can force that media feature.

Related issue(s)

  • fixes SWC-2412

Author's checklist

  • I have read the CONTRIBUTING and PULL_REQUESTS documents.
  • I have reviewed the Accessibility Practices for this feature, see: Aria Practices
  • I have added automated tests to cover my changes.
  • I have included a well-written changeset if my change needs to be published.
  • I have included updated documentation if my change required it.

Accessibility testing checklist

  • Keyboard: no focusable parts added; progress-circle is non-interactive, so no keyboard flow to verify beyond confirming no regressions in existing stories.
  • Screen reader: new stories only exercise existing behavior (role="progressbar", aria-valuenow/aria-valuetext on determinate, label fallback on indeterminate); confirm announcements are unchanged from pre-existing coverage.

@cdransf
cdransf requested a review from a team as a code owner August 10, 2026 23:33
@changeset-bot

changeset-bot Bot commented Aug 10, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: d2fa025

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cdransf cdransf added Component:Progress circle Status:Ready for review PR ready for review or re-review. Spectrum 2 Issues related to Spectrum 2 run_vrt Triggers the Chromatic VRT run for 2nd-gen labels Aug 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

📚 Branch Preview Links

🔍 Gen1 Visual Regression Test Results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Deployed to Azure Blob Storage: pr-6600

If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component:Progress circle run_vrt Triggers the Chromatic VRT run for 2nd-gen Spectrum 2 Issues related to Spectrum 2 Status:Ready for review PR ready for review or re-review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant