You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds Storybook VRT coverage for progress-circle: independent size and state rows (indeterminate, 0/25/50/75/100 determinate, one labeled row per state so indeterminate can't collide visually with a determinate value), static-color states on contrast backgrounds, forced-colors, and custom-property reference/override rows; test-only, no runtime code changes.
Motivation and context
SWC-2412 requires VRT coverage for progress-circle following the button/divider/card/meter VRT foundation (#6463); no global-styles VRT file since the component has no plain-element equivalent, and no reduced-motion story since no existing tooling in this repo can force that media feature.
I have reviewed the Accessibility Practices for this feature, see: Aria Practices
I have added automated tests to cover my changes.
I have included a well-written changeset if my change needs to be published.
I have included updated documentation if my change required it.
Accessibility testing checklist
Keyboard: no focusable parts added; progress-circle is non-interactive, so no keyboard flow to verify beyond confirming no regressions in existing stories.
Screen reader: new stories only exercise existing behavior (role="progressbar", aria-valuenow/aria-valuetext on determinate, label fallback on indeterminate); confirm announcements are unchanged from pre-existing coverage.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
If the changes are expected, update the current_golden_images_cache hash in the circleci config to accept the new images. Instructions are included in that file.
If the changes are unexpected, you can investigate the cause of the differences and update the code accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Storybook VRT coverage for
progress-circle: independent size and state rows (indeterminate, 0/25/50/75/100 determinate, one labeled row per state so indeterminate can't collide visually with a determinate value), static-color states on contrast backgrounds, forced-colors, and custom-property reference/override rows; test-only, no runtime code changes.Motivation and context
SWC-2412 requires VRT coverage for
progress-circlefollowing the button/divider/card/meter VRT foundation (#6463); no global-styles VRT file since the component has no plain-element equivalent, and no reduced-motion story since no existing tooling in this repo can force that media feature.Related issue(s)
Author's checklist
Accessibility testing checklist
role="progressbar",aria-valuenow/aria-valuetexton determinate,labelfallback on indeterminate); confirm announcements are unchanged from pre-existing coverage.