Skip to content

Conversation

@Agaba-derrick
Copy link
Contributor

Summary

This PR updates genTestFolderList to dynamically discover JCK test directories instead of relying on hard-coded version-specific paths. This ensures new test targets are automatically detected as the JCK layout evolves.

What Changed

  • Removed version-based directory assumptions (e.g., *-runtime-$ver)
  • Added dynamic directory scanning for:
    • runtime
    • compiler
    • devtools
  • Improved resilience to future JCK repository structure changes

Why

As test materials evolve over time, the previous static approach could miss new test folders. This update keeps target detection accurate and future-proof.

Issue

Closes #6761

@Agaba-derrick
Copy link
Contributor Author

Agaba-derrick commented Dec 5, 2025

@llxia @smlambert kindly asking for a review

@smlambert
Copy link
Contributor

hi @Agaba-derrick - this is not the change I expected for this one. I was hoping for the most minimal change to this file, essentially changing this block
to

	if [ "$VERSION" -eq 8 ] ; then 
		ver="$VERSION"c
	elif [ "$VERSION" -eq 11 ] ; then 
		ver="$VERSION"a
	else 
		ver="$VERSION"
	fi 

@Agaba-derrick
Copy link
Contributor Author

hi @Agaba-derrick - this is not the change I expected for this one. I was hoping for the most minimal change to this file, essentially changing this block to

	if [ "$VERSION" -eq 8 ] ; then 
		ver="$VERSION"c
	elif [ "$VERSION" -eq 11 ] ; then 
		ver="$VERSION"a
	else 
		ver="$VERSION"
	fi 

thanks @smlambert i will change this Asap !

@smlambert
Copy link
Contributor

@Agaba-derrick - see these lines, you will need to deal with both 11 and 17 (my example only did 11)

@smlambert smlambert requested a review from sophia-guo December 5, 2025 15:24

genTestFolderList() {
if [ "$VERSION" -eq 8 ] ; then
if [ "$VERSION" -eq 8 ] ; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor note: there is a unintended extra indentation, we can keep as before.

find . -maxdepth 2 -mindepth 2 -type d > $outputdir/compiler-dirs.txt

if [ $ver == "8c" ]; then
if [ "$ver" == "8c" ] || [ "$ver" == "11a" ] || [ "$ver" == "17a" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no devtools for 11 and 17. So we can keep this as before.

@smlambert
Copy link
Contributor

@Agaba-derrick - please address @sophia-guo 's recent review comments after which we will be good to merge

@Agaba-derrick
Copy link
Contributor Author

@smlambert le me work on these Asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update genTestFolderList to search updated directories

3 participants