-
-
Notifications
You must be signed in to change notification settings - Fork 335
Update genTestFolderList to dynamically detect test directories #6775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Update genTestFolderList to dynamically detect test directories #6775
Conversation
Signed-off-by: Agaba-derrick <[email protected]>
|
@llxia @smlambert kindly asking for a review |
|
hi @Agaba-derrick - this is not the change I expected for this one. I was hoping for the most minimal change to this file, essentially changing this block |
thanks @smlambert i will change this Asap ! |
Signed-off-by: Agaba-derrick <[email protected]>
|
@Agaba-derrick - see these lines, you will need to deal with both 11 and 17 (my example only did 11) |
Signed-off-by: Agaba-derrick <[email protected]>
|
|
||
| genTestFolderList() { | ||
| if [ "$VERSION" -eq 8 ] ; then | ||
| if [ "$VERSION" -eq 8 ] ; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor note: there is a unintended extra indentation, we can keep as before.
| find . -maxdepth 2 -mindepth 2 -type d > $outputdir/compiler-dirs.txt | ||
|
|
||
| if [ $ver == "8c" ]; then | ||
| if [ "$ver" == "8c" ] || [ "$ver" == "11a" ] || [ "$ver" == "17a" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no devtools for 11 and 17. So we can keep this as before.
|
@Agaba-derrick - please address @sophia-guo 's recent review comments after which we will be good to merge |
|
@smlambert le me work on these Asap |
Summary
This PR updates
genTestFolderListto dynamically discover JCK test directories instead of relying on hard-coded version-specific paths. This ensures new test targets are automatically detected as the JCK layout evolves.What Changed
*-runtime-$ver)runtimecompilerdevtoolsWhy
As test materials evolve over time, the previous static approach could miss new test folders. This update keeps target detection accurate and future-proof.
Issue
Closes #6761