unixPB: improves download and verify of ant binary #3752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mahdipub linter failures |
mahdipub
force-pushed
the
ant_installation_improvement
branch
from
ab3560a to
2b760af
Compare
Thanks, resolved. |
karianna
requested changes
Oct 1, 2024
mahdipub
force-pushed
the
ant_installation_improvement
branch
from
2b760af to
02c0534
Compare
|
@mahdipub Please avoid force pushing into PRs unless you really need to while people are reviewing as it makes it very hard to see what has been updated since the last time you looked. |
karianna
approved these changes
Dec 5, 2024
|
@mahdipub Will need a rebase |
by replacing command: wget with get_url module, it helps to support more systems. Also while running GPG Signature verification some systems (e.g old mac machines) have problem with wget while running package_signature_verification.sh. This change makes sure all systems will find wget in their PATH. Sigend-off-by: [email protected]
mahdipub
force-pushed
the
ant_installation_improvement
branch
from
6b722a1 to
dceb54b
Compare
Done. |
karianna
approved these changes
Dec 8, 2024
|
Needs a re-run of VPC once the jenkins server is back up and running |
@mahdipub Assuming you still want to get this in, can you rebase your changes on top of master as there's some fixes we need in there to be able to run these checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by replacing
command: wgetwithget_urlmodule, it helps to support more systems. Also while runningGPG Signature verificationsome systems (e.g old mac machines) have problem with wget while runningpackage_signature_verification.sh. This change makes sure all systems will find wget in theirPATH.Sigend-off-by: [email protected]
Checklist