Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Aug 21, 2025

This PR fixes a lint warning in the devkit role's main.yml file where Jinja2 template spacing could be improved.

The issue was on line 26 in the checksum field where the replace filter calls were missing spaces after commas:

Before:

checksum: "sha256:{{ lookup('vars', 'csum_' + ansible_architecture + '_' + devkit_version | replace('.','_') | replace('-','_'))}}"

After:

checksum: "sha256:{{ lookup('vars', 'csum_' + ansible_architecture + '_' + devkit_version | replace('.', '_') | replace('-', '_')) }}"

The changes follow Ansible/Jinja2 best practices by:

  • Adding spaces after commas in the replace filter parameters
  • Adding a space before the closing }} brackets

This is a minimal formatting fix that improves code readability and resolves the ansible-lint warning without changing any functionality.

Fixes #4035.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • galaxy.ansible.com
    • Triggering command: /usr/bin/python3 /home/REDACTED/.local/bin/ansible-galaxy collection install -r /home/REDACTED/work/infrastructure/infrastructure/collections/requirements.yml (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Author

Copilot AI commented Aug 21, 2025

@karianna 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

@Copilot Copilot AI changed the title [WIP] Lint warning on line 22 in ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/devkit/tasks/main.yml Fix Jinja2 spacing in devkit checksum template Aug 21, 2025
@Copilot Copilot AI requested a review from karianna August 21, 2025 10:19
Copilot finished work on behalf of karianna August 21, 2025 10:19
@karianna
Copy link
Contributor

Example Copilot based PR for PMC to discuss how to deal with coding agents for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint warning in ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/devkit/tasks/main.yml
2 participants