Skip to content

refactor(search): rewrite search page with nuqs URL state #828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thostetler wants to merge 3 commits into
base: master
Choose a base branch
from

fix(facets): gate isLoading on query enabled state to prevent stuck s…

ba7664c
Select commit
Loading
Failed to load commit list.
Draft

refactor(search): rewrite search page with nuqs URL state #828

fix(facets): gate isLoading on query enabled state to prevent stuck s…
ba7664c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 21, 2026 in 0s

62.4% (-0.0%) compared to bb93ce0

View this Pull Request on Codecov

62.4% (-0.0%) compared to bb93ce0

Details

Codecov Report

❌ Patch coverage is 68.07474% with 393 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.4%. Comparing base (bb93ce0) to head (ba7664c).

Files with missing lines Patch % Lines
src/components/SearchFacet/FacetTree.tsx 29.5% 261 Missing and 2 partials ⚠️
src/pages/search/index.tsx 75.5% 55 Missing ⚠️
src/components/SearchFacet/FacetPagination.tsx 34.7% 34 Missing ⚠️
.../components/EmailNotifications/Forms/QueryForm.tsx 13.4% 13 Missing ⚠️
src/components/ResultList/Item/Item.tsx 68.5% 1 Missing and 5 partials ⚠️
src/components/Visualizations/Graphs/Histogram.tsx 0.0% 6 Missing ⚠️
src/components/SearchFacet/useGetFacetData.ts 68.8% 3 Missing and 2 partials ⚠️
src/components/SearchFacet/YearHistogramSlider.tsx 33.4% 4 Missing ⚠️
src/components/AbstractSideNav/AbstractSideNav.tsx 87.5% 2 Missing ⚠️
...c/components/SearchBar/hooks/UseSyncWithGlobal.tsx 80.0% 2 Missing ⚠️
... and 3 more
Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #828     +/-   ##
========================================
- Coverage    62.4%   62.4%   -0.0%     
========================================
  Files         317     337     +20     
  Lines       36565   38685   +2120     
  Branches     1670    1764     +94     
========================================
+ Hits        22816   24119   +1303     
- Misses      13711   14510    +799     
- Partials       38      56     +18
Files with missing lines Coverage Δ
src/api/search/models.ts 52.9% <100.0%> (+7.1%) ⬆️
src/components/ResultList/ListActions.tsx 78.3% <100.0%> (+0.3%) ⬆️
src/components/SearchFacet/config.ts 100.0% <100.0%> (ø)
src/components/SearchQueryLink/SearchQueryLink.tsx 78.3% <100.0%> (+4.0%) ⬆️
...components/SearchResultsList/SearchResultsList.tsx 100.0% <100.0%> (ø)
...onents/SearchResultsList/SearchResultsSkeleton.tsx 100.0% <100.0%> (ø)
src/components/Select/Select.tsx 77.6% <100.0%> (ø)
src/components/Sort/Sort.tsx 81.2% <100.0%> (+0.7%) ⬆️
src/lib/search/filterBoundFq.ts 100.0% <100.0%> (ø)
src/lib/search/toApiParams.ts 100.0% <100.0%> (ø)
... and 20 more

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov