Skip to content

Restructured to have unit tests working #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 27, 2023
Merged

Restructured to have unit tests working #1

merged 13 commits into from
Jun 27, 2023

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Jun 27, 2023

Unit tests can now be executed with the following command:
codeql test run --show-extractor-output test/models
codeql test run --show-extractor-output test/queries

@mbaluda mbaluda requested a review from jeongsoolee09 June 27, 2023 11:01
@mbaluda mbaluda self-assigned this Jun 27, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The import path models.UI5::UI5 doesn't look very pretty but we can deal with that later.

@jeongsoolee09 jeongsoolee09 merged commit db14f6d into main Jun 27, 2023
@mbaluda mbaluda deleted the unit_tests branch June 28, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants