Add two log injection applications with custom listeners #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update usage of `sourceModel`, `sinkModel`, and `summaryModel` 2. Update usage of `XmlAttribute`, `XmlFile`
mbaluda
requested changes
May 22, 2024
There was a problem hiding this comment.
- Upload the new expected file
- The CodeQL versions for unit tests and code scanning do not match. We should probably update qlt.conf.json and the
qlpack.ymlfiles.
Otherwise revert your changes tosourceModeland use the 2.15.1 bundle (see CodeQL version fromqlt.conf.json#119)?
|
@jeongsoolee09 see PR #119:
|
CodeQL version from `qlt.conf.json`
mbaluda
approved these changes
May 23, 2024
| @@ -0,0 +1,3 @@ | |||
| nodes | |||
There was a problem hiding this comment.
It's expected to be empty, since we don't yet have a query to update the .expected files.
There was a problem hiding this comment.
I think in this case it's better to remove the file so that the unit test will be skipped
There was a problem hiding this comment.
That's better. I'll reopen the PR and remove the two .expected files.
There was a problem hiding this comment.
Instead of reopening the PR (I thought it was possible), I opened a new one that only removes the two files: #121.
| @@ -0,0 +1,3 @@ | |||
| nodes | |||
There was a problem hiding this comment.
It's expected to be empty, since we don't yet have a query to update the .expected files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR contributes
This PR adds two examples of log injection in happening in a UI5 application:
Example 1: Log entries consumed by a custom log listener
sap.base.Log, a collection of static logging functions, provides an extension point for a developer to add arbitrary code that handles a log entry as it is created. The developer has to define an object that implements a interface methodsap.base.LogListener.onLogEntrythat is called if a log entry is created.The example provides a custom log listener under
webapp/utils/CustomLogListener.jswhoseonLogEntrysends the log entry via HTTP.Example 2: Log entries consumed by
sap.ui.vk.Notificationssap.ui.vk.Notificationsis a control provided in the namespacesap.ui.vk. The control implementsLog.onLogEntry()and registers itself toLogusingLog.addLogListenerinternally. Since it is a control provided by SAP themselves, it would be a good idea to include this as a separate example.The example declares a use of
sap.ui.vk.Notificationsin itsview/app.view.xmlwhich automatically picks up log entries and displays it on screen as a notification entry.Future work
If SAP requests for it, refine the existing log injection query to take into consideration the additional elements living in both examples.