Skip to content

Adjust cap log sinks #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2024
Merged

Adjust cap log sinks #130

merged 2 commits into from
Jul 23, 2024

Conversation

knewbury01
Copy link
Contributor

exclude only constant only template literals

@knewbury01 knewbury01 self-assigned this Jul 22, 2024
jeongsoolee09
jeongsoolee09 requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I commented for a minor stylish change.

@knewbury01 knewbury01 requested a review from jeongsoolee09 July 22, 2024 23:39
jeongsoolee09
jeongsoolee09 approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jeongsoolee09 jeongsoolee09 merged commit abb32f1 into main Jul 23, 2024
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the knewbury01/fix-log-sink branch July 23, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongsoolee09 jeongsoolee09 jeongsoolee09 approved these changes

@mbaluda mbaluda Awaiting requested review from mbaluda

Assignees

@knewbury01 knewbury01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knewbury01 @jeongsoolee09