Skip to content

Add help files to Authentication/Authorization queries #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 14, 2024

Conversation

jeongsoolee09
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 commented Aug 9, 2024

What this PR Contributes

Add help files for the authentication / authorization related queries from #113.

Future work

  • Bump version and publish pack, shoot a demo video.
  • As per SAP's explanation on the dynamically-generated-privileged, fix CDS.qll library that reflects my misunderstanding on CAP.
  • Implement query dynamically-generated-privileged, write help file, publish it.

@jeongsoolee09 jeongsoolee09 self-assigned this Aug 12, 2024
@jeongsoolee09 jeongsoolee09 requested a review from mbaluda August 12, 2024 23:03
@jeongsoolee09 jeongsoolee09 marked this pull request as ready for review August 12, 2024 23:03
Copy link
Contributor

@mbaluda mbaluda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good!
I suggested some minor improvements to the text.
Should the future work go in an issue? I don't think it should be in the PR

@jeongsoolee09
Copy link
Contributor Author

@mbaluda Thanks for the suggestion, I'll make them live both here and in the issues as well.

@jeongsoolee09 jeongsoolee09 requested a review from mbaluda August 13, 2024 23:48
Copy link
Contributor

@mbaluda mbaluda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jeongsoolee09 jeongsoolee09 merged commit 277f6c2 into main Aug 14, 2024
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the jeongsoolee09/authn-queries-help branch August 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants