-
Notifications
You must be signed in to change notification settings - Fork 2
Add help files to Authentication/Authorization queries #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d-security/codeql-sap-js into jeongsoolee09/authn-queries-help
...script/frameworks/cap/src/bad-authn-authz/DefaultUserIsPrivileged/DefaultUserIsPrivileged.md
Outdated
Show resolved
Hide resolved
...script/frameworks/cap/src/bad-authn-authz/DefaultUserIsPrivileged/DefaultUserIsPrivileged.md
Outdated
Show resolved
Hide resolved
...script/frameworks/cap/src/bad-authn-authz/DefaultUserIsPrivileged/DefaultUserIsPrivileged.md
Outdated
Show resolved
Hide resolved
...pt/frameworks/cap/src/bad-authn-authz/EntityExposedWithoutAuthn/EntityExposedWithoutAuthn.md
Outdated
Show resolved
Hide resolved
...pt/frameworks/cap/src/bad-authn-authz/EntityExposedWithoutAuthn/EntityExposedWithoutAuthn.md
Outdated
Show resolved
Hide resolved
...pt/frameworks/cap/src/bad-authn-authz/EntityExposedWithoutAuthn/EntityExposedWithoutAuthn.md
Outdated
Show resolved
Hide resolved
...pt/frameworks/cap/src/bad-authn-authz/EntityExposedWithoutAuthn/EntityExposedWithoutAuthn.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good!
I suggested some minor improvements to the text.
Should the future work go in an issue? I don't think it should be in the PR
@mbaluda Thanks for the suggestion, I'll make them live both here and in the issues as well. |
Co-authored-by: Mauro Baluda <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
What this PR Contributes
Add help files for the authentication / authorization related queries from #113.
Future work
dynamically-generated-privileged
, fix CDS.qll library that reflects my misunderstanding on CAP.dynamically-generated-privileged
, write help file, publish it.