Skip to content

Adds XSJS CSRF and authorization queries #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 4, 2024
Merged

Adds XSJS CSRF and authorization queries #144

merged 9 commits into from
Sep 4, 2024

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Aug 28, 2024

Adds 2 queries and related tests:

  • Broken XSJS authentication
  • Disabled XSJS CSRF protection

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 28, 2024
View reviewed changes
@mbaluda mbaluda self-assigned this Aug 28, 2024
@mbaluda mbaluda requested a review from jeongsoolee09 August 28, 2024 20:59
jeongsoolee09
jeongsoolee09 reviewed Sep 3, 2024
View reviewed changes
javascript/frameworks/xsjs/src/XSJSAuthentication/XSJSAuthentication.md
```

## References

Copy link
Contributor

@jeongsoolee09 jeongsoolee09 Sep 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A link to the documentation page about xs-app.json may be a useful addition: https://help.sap.com/docs/SAP_HANA_PLATFORM/4505d0bdaf4948449b7f7379d24d0f0d/5f77e58ec01b46f6b64ee1e2afe3ead7.html

jeongsoolee09
jeongsoolee09 requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're off to a good start! I've left some thoughts here and there.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 4, 2024
View reviewed changes
jeongsoolee09
jeongsoolee09 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeongsoolee09 jeongsoolee09 merged commit 4b2580a into main Sep 4, 2024
5 checks passed
@jeongsoolee09 jeongsoolee09 deleted the mbaluda/xsjs-access branch September 4, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongsoolee09 jeongsoolee09 jeongsoolee09 approved these changes

Assignees

@mbaluda mbaluda

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbaluda @jeongsoolee09