Skip to content

Deals with external .cds files #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Deals with external .cds files #150

merged 5 commits into from
Sep 24, 2024

Conversation

mbaluda
Copy link
Contributor

@mbaluda mbaluda commented Sep 19, 2024

  • Update CodeQL version
  • Standardize query ids
  • Include .cds files in the DB
  • Implement CdlObject location in the .cds file
  • Modified EntityExposedWithoutAuthn error message to include the name of the exposed element
  • Modified SensitiveExposure error message to include the name of the exposed element

- Update CodeQL version
- Standardize query ids
- Include `.cds` files in the DB
- Implement `CdlObject` location in the `.cds` file
- Modified `EntityExposedWithoutAuthn` error message to include the name of the exposed element
- Modified `SensitiveExposure` error message to include the name of the exposed element
@mbaluda mbaluda requested review from jeongsoolee09 and knewbury01 and removed request for jeongsoolee09 September 19, 2024 09:13
Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left some suggestions and comments.

Copy link
Contributor

@jeongsoolee09 jeongsoolee09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! :shipit:

@mbaluda mbaluda merged commit 7c97de6 into main Sep 24, 2024
5 checks passed
@mbaluda mbaluda deleted the mbaluda/cds branch September 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants