Address FN involving CAP remote flow sources #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ervice` - Extension to definitions: - Add an explicit case named `ExportedClosureApplicationServiceDefinition` of a `UserDefinedApplicationService` that is defined in the form of an exported function whose first parameter represents the service instance. - Add a definition `ServiceInstanceFromExportedClosureParameter` that matches above class. - Bug fixes: - Address a bug in the `UserDefinedApplicationService.isExposed/0` where a simple negation also captured cases where CDS declarations were missing. - Address a bug in the `HandlerParameterOfExposedService` where the trailing `.getCdsDeclaration()` was missing. NOTE: See issue #221 to learn more about the `HACK` block comment.
knewbury01
reviewed
Aug 25, 2025
| * This class captures the `srv` parameter of the exported arrow function. Also see | ||
| * `ServiceInstanceFromImplMethodCallClosureParameter` which is similar to this. | ||
| */ | ||
| class ServiceInstanceFromExportedClosureParameter extends ServiceInstance { |
There was a problem hiding this comment.
should this also extend ParameterNode like ServiceInstanceFromImplMethodCallClosureParameter does? not too sure if its really necessary/makes anything easier predicate availability wise tho
There was a problem hiding this comment.
Addressed in 6514387.
|
overall this looks really good to me! couple of small extra things
|
|
@knewbury01 Additional cases are added to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
This PR fixes false negative cases where the current CAP remote flow source definition
UserProvidedPropertyReadOfHandlerParameterOfExposedServiceis missing detections from the code that comes in the following form:Two things are notable in the above case:
Unfortunately, the CodeQL Standard Library for JavaScript cannot detect the above
(srv) => { srv.on(...) }element due to some limitations (see issue #221). Therefore, we directly describe the above patternmodule.exports = (...) => { ... }as a hack around it.Other than that, the code changes include:
ExportedClosureApplicationServiceDefinitionof aUserDefinedApplicationServicethat is defined in the form of an exported function whose first parameter represents the service instance.ServiceInstanceFromExportedClosureParameterthat matches above class.UserDefinedApplicationService.isExposed/0where a simple negation also captured cases where CDS declarations were missing.HandlerParameterOfExposedServicewhere the trailing.getCdsDeclaration()was missing.Future Works
Remove the "hack around it" once the relevant portion of the library is patched and released.