Skip to content

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented Nov 14, 2025

Primary Changes in this PR

  1. Upgrade CodeQL CLI to v2.23.5 and update associated qlpack dependencies.
  2. Changed CDS extractor behavior to create a cds-extractor-marker.js file with dummy/placeholder content of a given/scanned SOURCE_ROOT directory, which is a workaround for a change in CodeQL's javascript extractor behavior (starting in v2.23.5).

Outline of Changes in this PR

Extraction flow and error handling improvements:

  • Refactored the main extraction flow in cds-extractor.ts to use new utility functions (handleEarlyExit and runJavaScriptExtractionWithMarker) for early exit scenarios and JavaScript extraction, resulting in cleaner code and more consistent error handling. [1] [2] [3]
  • Improved diagnostics and logging throughout the extraction process, including more detailed reporting when no CDS projects are found and better handling of dependency installation failures. [1] [2] [3] [4]

Code organization and reuse:

  • Added new utility functions to codeql.ts for running JavaScript extraction with marker file handling and for handling early exit scenarios, promoting code reuse and reducing duplication.
  • Updated imports and removed unused code in cds-extractor.ts to reflect the new utility functions and streamline the script.

Dependency and compatibility updates:

  • Upgraded both runtime and development dependencies in package.json to their latest versions, improving compatibility and security.
  • Updated the usage of spawnSync in compiler/version.ts and codeql.ts to avoid Node.js deprecation warnings and ensure proper command execution. [1] [2]

[1] [2] [3] [4] [5] [6] [7]

@github-actions github-actions bot force-pushed the codeql/upgrade-to-v2.23.5 branch from 2ffc9ae to 10d1f7e Compare November 18, 2025 00:50
@data-douser data-douser reopened this Nov 20, 2025
@data-douser data-douser changed the title Upgrade CodeQL CLI dependency to v2.23.5 Refactor CDS extractor for compatibility with upgraded CodeQL v2.23.5 Nov 26, 2025
@data-douser data-douser merged commit 2e9aaf6 into main Dec 1, 2025
6 checks passed
@data-douser data-douser deleted the codeql/upgrade-to-v2.23.5 branch December 1, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants