Update kamaji version #633
Conversation
* Stripped port number from KamajiControlPlane hostname due to clastix/kamaji#679 * Bumped versions for kamaji and dependent charts
dosubot
bot
added
the
size:XS
WalkthroughThis pull request updates several configuration and deployment files. It removes a hardcoded port from the hostname in the ingress section, upgrades version numbers in the Kamaji Dockerfile, Kubernetes Chart, installer script, and version mapping, and corrects migration comments. A new migration script has also been added to update application configurations via Kubernetes commands. These changes adjust versioning and patching approaches without altering core functionality. Changes
Sequence Diagram(s)sequenceDiagram
participant M as Migration Script
participant K as Kubernetes API
M->>K: Update kubernetes.apps.cozystack.io (set appVersion to 0.15.1)
K-->>M: Acknowledgement
M->>K: Create/Update ConfigMap (cozystack-version = 10)
K-->>M: Acknowledgement
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| hostname: {{ .Values.host | default (printf "%s.%s" .Release.Name $host) }}:443 | ||
| hostname: {{ .Values.host | default (printf "%s.%s" .Release.Name $host) }} |
There was a problem hiding this comment.
Please bump version of Chart.yaml for kubernetes application.
Also, if old clusters will continue using :443 in their configuration they will beblocked, how about adding migration script, to bump all Kubernetes clusters to that version?
packages/system/kamaji/values.yaml
Outdated
| tag: v0.25.3@sha256:229646a728b58dd0c55dae7abd721ab23e3feecd61f55fa3ad24bb3a614d558f | ||
| tag: latest@sha256:04aaf9acb6f49e0315295cd0c24655f28b74c6cf628fc6721758842a41d2deef |
There was a problem hiding this comment.
Please omit these changes, version will be automatically bumped in release cycle
dosubot
bot
added
size:S
BREAKING: all kuberneteses will be upgraded to chart version 0.15.1
lllamnyp
force-pushed
the
119-update-kamaji
branch
from
68cb01e to
b321064
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
packages/apps/kubernetes/Chart.yaml(1 hunks)packages/apps/versions_map(1 hunks)scripts/installer.sh(1 hunks)scripts/migrations/8(1 hunks)scripts/migrations/9(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- scripts/migrations/8
- packages/apps/kubernetes/Chart.yaml
🔇 Additional comments (2)
scripts/installer.sh (1)
6-6: LGTM: Version increment aligns with new migration script.The version increment from 9 to 10 corresponds to the new migration script in
scripts/migrations/9that handles the upgrade process.packages/apps/versions_map (1)
47-48: LGTM: Version mapping updates follow established patterns.The changes correctly:
- Pin kubernetes 0.15.0 to specific commit cb7b815
- Add new kubernetes 0.15.1 pointing to HEAD
| # Migration 9 --> 10 | ||
|
|
||
| # Upgrade kubernetes.apps to new chart version | ||
| kubectl get kuberneteses.apps.cozystack.io -A -o yaml | sed -r -e 's/^ appVersion: [0-9.]+$/ appVersion: 0.15.1/' | kubectl apply -f- |
There was a problem hiding this comment.
From my point of view this should be more safe method:
| kubectl get kuberneteses.apps.cozystack.io -A -o yaml | sed -r -e 's/^ appVersion: [0-9.]+$/ appVersion: 0.15.1/' | kubectl apply -f- | |
| kubectl get kuberneteses.apps.cozystack.io -A --no-headers --output=custom-columns='NAMESPACE:.metadata.namespace,NAME:.metadata.name' | while read NAMESPACE NAME; do | |
| kubectl patch kuberneteses.apps.cozystack.io -n "$NAMESPACE" "$NAME" --type merge -p '{"appVersion":"0.15.1"}' | |
| done |
Summary by CodeRabbit
New Features
Chores
Refactor