Skip to content

[BUG]fixes /load_classification incorrectly deletes files and folders #2758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[BUG]fixes /load_classification incorrectly deletes files and folders #2758

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec937d5
Fix: prevent user-specified extract_path from being deleted on BadZip…
ItxJack Apr 21, 2025
578a46f
Fix: prevent user-specified extract_path from being deleted on BadZip…
ItxJack Apr 21, 2025
a6f2d55
Automatic `pre-commit` fixes
ItxJack Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions aeon/datasets/_data_loaders.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,10 +473,10 @@ def _download_and_extract(url, extract_path=None):
zipfile.ZipFile(zip_file_name, "r").extractall(extract_path)
shutil.rmtree(dl_dir)
return extract_path
except zipfile.BadZipFile:
shutil.rmtree(dl_dir)
if os.path.exists(extract_path):
shutil.rmtree(extract_path)

except zipfile.BadZipFile as e:
shutil.rmtree(dl_dir, ignore_errors=True)
print(f"[load_classification] Failed to unzip. Preserved path: {extract_path}")
raise zipfile.BadZipFile(
"Could not unzip dataset. Please make sure the URL is valid."
)
Expand Down
Loading