Skip to content

[REF] Refactor smoothing transformers into a sub-package #2783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[REF] Refactor smoothing transformers into a sub-package #2783

wants to merge 19 commits into from

Conversation

MatthewMiddlehurst
Copy link
Member

What does this implement/fix? Explain your changes.

#1920 implemented a set of smoothing filters. This PR does some tidying, refactors them into their own sub-package with more intuitive names and deprecates the old versions.

A lot of the old acronyms were not commonly used I believe, the new names and locations should make them more recognisable. Big offender was DFTSeriesTransformer which does an IFFT at the end. Bit confusing for someone who just wants to do a regular DFT.

Feel free to suggest alternatives. FYI @Cyril-Meyer @Datadote

@aeon-actions-bot aeon-actions-bot bot added refactor Restructuring without changing its external behavior transformations Transformations package labels May 8, 2025
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#BDD9DB}{\textsf{refactor}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Cyril-Meyer
Copy link
Contributor

@MatthewMiddlehurst good idea, the proposed new names looked good to me.
The only thing I do not find perfect is having 'smoothing' in the name when already in a 'smoothing' package (ExponentialSmoothing) but I do not have better alternative.

@Datadote
Copy link
Contributor

@MatthewMiddlehurst Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TonyBagnall TonyBagnall Awaiting requested review from TonyBagnall TonyBagnall is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
refactor Restructuring without changing its external behavior transformations Transformations package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MatthewMiddlehurst @Cyril-Meyer @Datadote