Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-567 | Refactor method_not_allowed response message to be API_ERROR #430

Conversation

idilalemdar
Copy link
Contributor

@idilalemdar idilalemdar commented Jan 12, 2025

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

Copy link
Collaborator

@agitrubard agitrubard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@idilalemdar Diğer bütün arkadaşları da reviewer olarak ekleyebilir miyiz? Ek olarak bundan sonra branch oluştururken branch standartlarını da takip edebilirsek daha takip edilebilir ve okunabilir branch'lere sahip olmuş oluruz. Örneklerine açık olan branch'lerden bakılabilir

@idilalemdar
Copy link
Contributor Author

@idilalemdar Diğer bütün arkadaşları da reviewer olarak ekleyebilir miyiz? Ek olarak bundan sonra branch oluştururken branch standartlarını da takip edebilirsek daha takip edilebilir ve okunabilir branch'lere sahip olmuş oluruz. Örneklerine açık olan branch'lerden bakılabilir

branch naming convention'a göre açmıştım ama?

@idilalemdar idilalemdar merged commit 13c0ed7 into main Jan 13, 2025
6 checks passed
@idilalemdar idilalemdar deleted the refactor/AYS-567/405-Method-Not-Allowed-Hatas-in-Header-Bilgisinin-G-ncellenmesi branch January 13, 2025 08:08
@agitrubard
Copy link
Collaborator

branch naming convention'a göre açmıştım ama?

@idilalemdar örnek olarak türkçe yazmak yerine refactor/AYS-567/method-not-allowed olabilir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants