Skip to content

Commit

Permalink
AYS-397 | Add eslint rules (#69)
Browse files Browse the repository at this point in the history
  • Loading branch information
sanshigo345 authored Sep 2, 2024
1 parent 2498c70 commit 352c16f
Show file tree
Hide file tree
Showing 59 changed files with 1,439 additions and 936 deletions.
18 changes: 18 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
{
"extends": [
"next/core-web-vitals",
"plugin:@typescript-eslint/recommended",
"plugin:prettier/recommended"
],
"parser": "@typescript-eslint/parser",
"plugins": ["@typescript-eslint", "prettier"],
"rules": {
"prettier/prettier": "warn",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/no-unused-vars": "warn",
"@typescript-eslint/ban-ts-comment": "warn",
"@typescript-eslint/ban-types": "warn",
"@typescript-eslint/explicit-function-return-type": "warn",
"@typescript-eslint/no-empty-function": "warn"
}
}
6 changes: 0 additions & 6 deletions .eslintrc.json

This file was deleted.

3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ yarn-error.log*
# vercel
.vercel

# vscode
.vscode

# typescript
*.tsbuildinfo
next-env.d.ts
Expand Down
4 changes: 4 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
node_modules

build
coverage
13 changes: 10 additions & 3 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
{
"semi": false,
"printWidth": 80,
"tabWidth": 2,
"singleQuote": true,
"endOfLine": "lf"
}
"bracketSpacing": true,
"semi": false,
"useTabs": false,
"bracketSameLine": false,
"jsxSingleQuote": false,
"arrowParens": "always",
"endOfLine": "lf",
"trailingComma": "es5"
}
35 changes: 21 additions & 14 deletions PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,31 +10,38 @@ Before submitting your pull request, ensure the following:
- [ ] Other (please specify)

- [ ] **Summary:**
- Add a short description (e.g., added or modified features).

- Add a short description (e.g., added or modified features).

- [ ] **Title and Branch Naming Conventions:**
- The pull request title follows the
standard: [Pull Request Naming Conventions](CONTRIBUTING.md#pull-request-naming-conventions).
- The branch name follows one of the conventions outlined in
the [Branch Naming Conventions](CONTRIBUTING.md#branch-naming-conventions).

- The pull request title follows the
standard: [Pull Request Naming Conventions](CONTRIBUTING.md#pull-request-naming-conventions).
- The branch name follows one of the conventions outlined in
the [Branch Naming Conventions](CONTRIBUTING.md#branch-naming-conventions).

- [ ] **Local Testing:**
- I have tested my changes locally on my browser, and they are working as expected.

- I have tested my changes locally on my browser, and they are working as expected.

- [ ] **Code Quality:**
- The code is formatted according to the project's coding guidelines and style.
- The code has been reviewed to ensure its quality.
- The code does not contain any issues flagged by ESLint.

- The code is formatted according to the project's coding guidelines and style.
- The code has been reviewed to ensure its quality.
- The code does not contain any issues flagged by ESLint.

- [ ] **Documentation:**
- Necessary documentation has been added or existing documentation has been updated.

- Necessary documentation has been added or existing documentation has been updated.

- [ ] **Reviewers and Assignees:**
- Default reviewers have been assigned to this pull request.
- Assignees have been added if necessary.

- Default reviewers have been assigned to this pull request.
- Assignees have been added if necessary.

- [ ] **Related Issue:**
- Closes #AYS-345 (If there is a relevant issue)

- Closes #AYS-345 (If there is a relevant issue)

- [ ] **Labels and Associations:**
- No specific actions are required in the Labels and Associations section for this pull request.
- No specific actions are required in the Labels and Associations section for this pull request.
Loading

0 comments on commit 352c16f

Please sign in to comment.